Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $PSMDST #189

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Add $PSMDST #189

merged 1 commit into from
Feb 6, 2021

Conversation

joabakk
Copy link
Contributor

@joabakk joabakk commented Feb 2, 2021

Same as $STALK, replaces #188

@joabakk joabakk mentioned this pull request Feb 2, 2021
Closed
@joabakk
Copy link
Contributor Author

joabakk commented Feb 2, 2021

I am struggling with the "sessions". The position and time tests pass for $STALK, but for some reason not for $SPMDST

@tkurki
Copy link
Member

tkurki commented Feb 2, 2021

Simple: ALK.js uses session, PSMDST.js doesn't.

@joabakk
Add $PSMDST
05d7fb5 
Same as $STALK
@joabakk
Copy link
Contributor Author

joabakk commented Feb 2, 2021

Simple: ALK.js uses session, PSMDST.js doesn't.

Argh. Thanks again

@tkurki tkurki merged commit c86fdbb into SignalK:master Feb 6, 2021
@joabakk joabakk deleted the psmdst branch February 11, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joabakk @tkurki