Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split sentences to files and add conversions #10

Merged
merged 3 commits into from
Oct 9, 2017
Merged

Conversation

tkurki
Copy link
Member

@tkurki tkurki commented Sep 7, 2017

Original effort #8 restructured and cleaned up a bit.

Adds numerous conversions, the list is now

  • APB
  • DBK
  • DBS
  • DBT
  • DPT
  • GLL
  • HDG
  • HDM
  • HDMC
  • HDT
  • MMB
  • MTA
  • MTW
  • MWD
  • MWVR
  • MWVT
  • PNKEP01
  • PNKEP02
  • PNKEP03
  • PNKEP99
  • RMB
  • RMC
  • ROT
  • TODO
  • VHW
  • VLW
  • VTG
  • VWR
  • VWT
  • XDRBaro
  • XDRTemp
  • XTE
  • ZDA

@tkurki
Copy link
Member Author

tkurki commented Sep 7, 2017

@joabakk some of the new sentences here might be of interest to you - your thoughts?

@tkurki tkurki changed the title [WIP] Split sentences to files and add conversions Split sentences to files and add conversions Sep 8, 2017
@joabakk
Copy link
Contributor

joabakk commented Sep 8, 2017

Looks good to me, from a brief look. Perhaps with the exception of PNKEP99.js which seems to be a debugging sentence?

Additional conversions by https://github.com/ieb from
#8.

chore: remove unused dummy file
@tkurki tkurki merged commit 6283364 into master Oct 9, 2017
@tkurki tkurki deleted the refactor-nmea-split branch October 9, 2017 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants