Restructured to allow sentences to be loaded from files #8
Conversation
…e NKE sentences. Needs derived data to work
| 'N' | ||
| ]); | ||
| function mapToNmea(encoder, name) { | ||
| if ( encoder.ttl === undefined) { |
There was a problem hiding this comment.
Did I understand this right: none of the encoders have ttl defined and it can only be used in encoders, not user defined?
There was a problem hiding this comment.
the intention was that the encoder could define it if required. I didnt find I needed to reduce the frequency on my network. I guess it could be user defined as an alternative. Things like pressure and temperature don't need to be ever 2s.
Additional conversions by https://github.com/ieb from #8.
|
There are several small things with your PR that I thought I'd sooner fix myself. Stuff like copypasted function being name mwv in HDM.js, global variables leaking, bug in fixAngle etc. I created a new PR on top of the recent changes in master #10. It has all the new conversions, but not the skipduplicates etc, which I would like to introduce properly (user configurable) instead of being there but not being used at all. The commit message also refers to this PR. I hope this is ok with you @ieb ? |
|
yes, lgtm |
Additional conversions by https://github.com/ieb from #8. chore: remove unused dummy file
Additional conversions by https://github.com/ieb from #8. chore: remove unused dummy file
Apologies for the size of the patch.
This restructures the module into 1 file per sentence and adds some NKE performance related sentences that are understood by the NKE app. The performance data is calculated in SignalK/signalk-derived-data#7
The calculations have been checked and look ok but might have errors.