Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Provide Manual option for vertical position of tooltip #306

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

HappyMakadiyaS
Copy link
Collaborator

@HappyMakadiyaS HappyMakadiyaS commented Nov 21, 2022

Description

Provide manual option for the verical position of tooltip
TooltipPosition.top and TooltipPosition.bottom

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@HappyMakadiyaS HappyMakadiyaS force-pushed the feature/manual_tootltip_position branch from eb95f38 to 28fcaca Compare November 21, 2022 07:48
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ujas-m-simformsolutions
Copy link
Contributor

Also if you haven't added tests then uncheck it the checklist.

@ujas-m-simformsolutions ujas-m-simformsolutions force-pushed the feature/manual_tootltip_position branch from 28fcaca to ada1dd0 Compare January 3, 2023 10:04
Copy link
Contributor

@ujas-m-simformsolutions ujas-m-simformsolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DhvanitVaghani DhvanitVaghani force-pushed the feature/manual_tootltip_position branch from ada1dd0 to ea1cd00 Compare January 3, 2023 14:33
@vatsaltanna vatsaltanna merged commit f5b348e into master Jan 3, 2023
@vatsaltanna vatsaltanna deleted the feature/manual_tootltip_position branch January 3, 2023 14:40
satria-wardana added a commit to satria-wardana/flutter_showcaseview that referenced this pull request Sep 7, 2023
* master: (55 commits)
  📝 Update CHANGELOG.md file for version 2.0.3. (SimformSolutionsPvtLtd#368)
  feat: ✨ Add callback when barrier has been clicked (SimformSolutionsPvtLtd#359)
  fixed-child-constructor-invocation (SimformSolutionsPvtLtd#361)
  ✨ (SimformSolutionsPvtLtd#148) Add feasibility to add `textDirection` of `title` and `description`. (SimformSolutionsPvtLtd#356)
  fix: 🐛 SimformSolutionsPvtLtd#346 Don't respond to any clicks in target & (SimformSolutionsPvtLtd#351)
  fix: 🐛 Flutter inspector makes screen grey (SimformSolutionsPvtLtd#353)
  🔖 version bump 2.0.0+1 to 2.0.1 (SimformSolutionsPvtLtd#341)
  fix: 🐛 Take in account view insets (such as keyboard) (SimformSolutionsPvtLtd#288)
  Miscellaneous changes
  Add missing copyright notice in enum.dart
  feat: ✨ Add padding to title and description
  fix: 🐛 PR title validation workflow issue (SimformSolutionsPvtLtd#322)
  feat: ✨ Provide Manual option for vertical position of tooltip (SimformSolutionsPvtLtd#306)
  feat: ✨ Enable/disable showcase globally. (SimformSolutionsPvtLtd#319)
  ✨ add mac support in example. (SimformSolutionsPvtLtd#197)
  Fix: 🔨 Remove title validation workflow (SimformSolutionsPvtLtd#321)
  chore: 👷workflow for PR title validation (SimformSolutionsPvtLtd#286)
  release: 🔖 version bump 2.0.0 to 2.0.0+1 (SimformSolutionsPvtLtd#302)
  release: 🔖 version bump 1.1.8 to 2.0.0 (SimformSolutionsPvtLtd#301)
  fix: 🐛 logic update in `tooltip_widget.dart` (SimformSolutionsPvtLtd#300)
  ...

# Conflicts:
#	example/ios/Flutter/AppFrameworkInfo.plist
#	example/ios/Runner.xcodeproj/project.pbxproj
#	example/lib/main.dart
#	lib/src/showcase.dart
#	lib/src/showcase_widget.dart
#	lib/src/tooltip_widget.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants