feat: ✨ Add feasibility to add textDirection of title and description.
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujas-m-simformsolutions
requested changes
Mar 15, 2023
Closed
DhvanitVaghani
force-pushed
the
feature/textdirection_support
branch
from
4977825 to
cc9d15e
Compare
README.md
Outdated
| @@ -182,6 +182,8 @@ WidgetsBinding.instance.addPostFrameCallback((_) => | |||
| | tooltipPosition | TooltipPosition? | | Defines vertical position of tooltip respective to Target widget | ✅ | ✅ | | |||
| | titlePadding | EdgeInsets? | EdgeInsets.zero | Padding to title | ✅ | | | |||
| | descriptionPadding | EdgeInsets? | EdgeInsets.zero | Padding to description | ✅ | | | |||
| | titleTextDirection | TextDirection? | | Give textDirection to title | ✅ | | | |||
| | descriptionPadding | TextDirection? | | Give textDirection to description | ✅ | | | |||
There was a problem hiding this comment.
descriptionPadding -> descriptionTextDirection
DhvanitVaghani
force-pushed
the
feature/textdirection_support
branch
from
cc9d15e to
a51ca3f
Compare
vatsaltanna
approved these changes
Mar 22, 2023
satria-wardana
added a commit
to satria-wardana/flutter_showcaseview
that referenced
this pull request
Sep 7, 2023
* master: (55 commits) 📝 Update CHANGELOG.md file for version 2.0.3. (SimformSolutionsPvtLtd#368) feat: ✨ Add callback when barrier has been clicked (SimformSolutionsPvtLtd#359) fixed-child-constructor-invocation (SimformSolutionsPvtLtd#361) ✨ (SimformSolutionsPvtLtd#148) Add feasibility to add `textDirection` of `title` and `description`. (SimformSolutionsPvtLtd#356) fix: 🐛 SimformSolutionsPvtLtd#346 Don't respond to any clicks in target & (SimformSolutionsPvtLtd#351) fix: 🐛 Flutter inspector makes screen grey (SimformSolutionsPvtLtd#353) 🔖 version bump 2.0.0+1 to 2.0.1 (SimformSolutionsPvtLtd#341) fix: 🐛 Take in account view insets (such as keyboard) (SimformSolutionsPvtLtd#288) Miscellaneous changes Add missing copyright notice in enum.dart feat: ✨ Add padding to title and description fix: 🐛 PR title validation workflow issue (SimformSolutionsPvtLtd#322) feat: ✨ Provide Manual option for vertical position of tooltip (SimformSolutionsPvtLtd#306) feat: ✨ Enable/disable showcase globally. (SimformSolutionsPvtLtd#319) ✨ add mac support in example. (SimformSolutionsPvtLtd#197) Fix: 🔨 Remove title validation workflow (SimformSolutionsPvtLtd#321) chore: 👷workflow for PR title validation (SimformSolutionsPvtLtd#286) release: 🔖 version bump 2.0.0 to 2.0.0+1 (SimformSolutionsPvtLtd#302) release: 🔖 version bump 1.1.8 to 2.0.0 (SimformSolutionsPvtLtd#301) fix: 🐛 logic update in `tooltip_widget.dart` (SimformSolutionsPvtLtd#300) ... # Conflicts: # example/ios/Flutter/AppFrameworkInfo.plist # example/ios/Runner.xcodeproj/project.pbxproj # example/lib/main.dart # lib/src/showcase.dart # lib/src/showcase_widget.dart # lib/src/tooltip_widget.dart
LocLt-Mobile
pushed a commit
to guide-inc-org/guide-flutter_showcaseview
that referenced
this pull request
Oct 28, 2023
… of `title` and `description`. (SimformSolutionsPvtLtd#356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ (#148) Add feasibility to add
textDirectionoftitleanddescription.Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues