Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ExprItemWithLore clone ItemType #3928

Merged
merged 4 commits into from
May 4, 2021
Merged

Make ExprItemWithLore clone ItemType #3928

merged 4 commits into from
May 4, 2021

Conversation

TPGamesNL
Copy link
Member

@TPGamesNL TPGamesNL commented Apr 27, 2021 •
edited
Loading

Description

Make ExprItemWithLore clone ItemType.
Test code:

command /test:
	trigger:
		set {_x} to stone
		set {_y} to {_x} with lore "abc"
		message "%lore of {_x}%"

Target Minecraft Versions: any
Requirements: none
Related Issues: #3901

@TPGamesNL TPGamesNL added 2.5 bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. labels Apr 27, 2021
@FranKusmiruk FranKusmiruk merged commit 62eb590 into SkriptLang:master May 4, 2021
@TPGamesNL TPGamesNL deleted the fix/expr-lore-clone-itemtype branch May 4, 2021 06:49
@AyhamAl-Ali AyhamAl-Ali mentioned this pull request Jun 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranKusmiruk FranKusmiruk FranKusmiruk approved these changes

Assignees
No one assigned
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TPGamesNL @FranKusmiruk