Add changers to ExprBookPages #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This class has been marked to be recoded at some point, so if you're adding changers to this class, the team is most likely going to suggest other additions to this class. First off it can be a PropertyExpression. Yes it's possible with the existing syntaxes to still have support for property expression. |
|
Should I do it in this PR? |
TheLimeGlass
suggested changes
Aug 11, 2022
AyhamAl-Ali
added
the
enhancement
AyhamAl-Ali
approved these changes
Aug 28, 2022
TheLimeGlass
suggested changes
Oct 15, 2022
TheLimeGlass
approved these changes
Oct 21, 2022
APickledWalrus
requested changes
Nov 24, 2022
APickledWalrus
requested changes
Dec 26, 2022
APickledWalrus
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds changers to the book pages expression
Target Minecraft Versions: Any
Requirements: None
Related Issues: I don't believe there are any