Fix and add chat format to books #5863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
bug
TheLimeGlass
requested review from
Moderocky,
AyhamAl-Ali,
APickledWalrus and
UnderscoreTud
TheLimeGlass
added
the
enhancement
Moderocky
approved these changes
Jul 28, 2023
sovdeeth
approved these changes
Aug 3, 2023
AyhamAl-Ali
reviewed
Aug 3, 2023
UnderscoreTud
approved these changes
Aug 8, 2023
AyhamAl-Ali
approved these changes
Aug 8, 2023
TheLimeGlass
added a commit
that referenced
this pull request
Aug 10, 2023
(cherry picked from commit 0590c6a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes and adds Skript's chat format to books.
The issues faced in ExprBookPages were;
player's toolreturns ItemStack now, and ExprBookPages only accepted ItemType meaning it would never actually apply to the correct ItemStack as it was converting to a new ItemType.acceptChangemethod, but has anassert falsein thechangemethod. The ADD changer was not working because of this.New addition example:
set page 1 of player's tool to "<tooltip:<##00ff00>you hovered over me!>&lTesting example!"Labeling as 2.7 due to #5025 adding the changers in 2.7 but not working properly.
Target Minecraft Versions: 1.16+ for the Skript chat format.
Requirements: Paper for the Skript chat format.
Related Issues: #5709