Fix InventoryItemMoveEvent Implementations (#5462) #6233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
approved these changes
Dec 14, 2023
|
tests 😍 |
Moderocky
previously requested changes
Dec 15, 2023
…t-initiator-inventory # Conflicts: # src/test/skript/junit/InventoryMoveItemEventTest.sk
|
Tests for this PR cannot be proceeded until #6261 and other issues related to delayed tests to be fixed in Skript's JUnit testing system. |
If the junit changes can't be made in time for 2.8, consider testing by just creating and calling a InventoryMoveEvent yourself. |
|
I'd like to have this in 2.8-pre1, @DelayedGaming, so would you be willing to either do (or let me do) the changes to the tests I suggested above as a stopgap until those JUnit fixes are done? |
sovdeeth
added
the
bug
sovdeeth
approved these changes
Dec 30, 2023
APickledWalrus
requested changes
Dec 30, 2023
src/test/java/org/skriptlang/skript/test/tests/syntaxes/InventoryMoveItemEventTest.java
Show resolved
Hide resolved
…initiator-inventory # Conflicts: # src/main/java/ch/njol/skript/classes/data/BukkitEventValues.java
APickledWalrus
approved these changes
Jan 1, 2024
sovdeeth
added
the
patch-ready
1 task
|
As #6451 points a pattern improvement, I decided to apply it into this PR as both are on the same page. |
Fusezion
suggested changes
Feb 27, 2024
Co-authored-by: Fusezion <fusezionstream@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #5462 where event values were unknowingly removed before the merge, with additions to
event-blocksupport and JUnit test.Target Minecraft Versions: any
Requirements: none
Related Issues: #5462, #6092