Remove final on 'cleanup' method and provide JUnit implementation warnings. #6261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLimeGlass
added
bug
sovdeeth
approved these changes
Dec 29, 2023
APickledWalrus
approved these changes
Dec 29, 2023
sovdeeth
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the final modifier on the 'cleanup' method, because this method will automatically cleanup all test data instantly, as JUnit runs instantly, and Skript itself will collect the results after the defined amount of shutdown time in ticks.
If a test is to be delayed, it needs to override the 'cleanup' method and do nothing in the method because the cleanup will happen at a later time in the junit script file code.
Added warnings to explain that if the test is delayed it needs to override the 'cleanup' method and do the cleanup itself.
Target Minecraft Versions: any
Requirements: none
Related Issues: none