Add villager expressions #7250
Merged
Add villager expressions #7250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this for now. |
TheAbsolutionism
approved these changes
Dec 12, 2024
sovdeeth
requested changes
Dec 15, 2024
src/main/java/ch/njol/skript/expressions/ExprVillagerLevel.java
Outdated
Show resolved
Hide resolved
…ture/villager-stuff
sovdeeth
approved these changes
Dec 17, 2024
Efnilite
requested changes
Dec 18, 2024
src/main/java/ch/njol/skript/expressions/ExprVillagerLevel.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Co-authored-by: Efnilite <35348263+Efnilite@users.noreply.github.com>
Efnilite
approved these changes
Dec 19, 2024
Efnilite
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add some useful expressions for villagers:
NOTES:
can't compare a villager profession with a living entityI had to add "profession" to each lang entry. I don't love this, but I don't see any way around it other than changing Villager's EntityData entries in the lang file.MathUtils was added due toMath.clamp()not being available on Java 17 (was added in Java 21)Target Minecraft Versions: any
Requirements: Relies on #7251
Related Issues: none