Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparators - add default comparators #7251

Merged

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to add default comparators to Registry/Enum ClassInfos.
Skript in the past has had issues comparing 2 of the same object, ex:
if biome at player = plains:
Skript get's upset:

[12:09:09 INFO]: Line 18: (test.sk)
[12:09:09 INFO]:     Can't compare a biome with a biome
[12:09:09 INFO]:     Line: if biome at player = plains:

Rather than registering a comparator for each and every Registry/Enum entry, this allows them to dynamically register.


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. 2.10 Targeting a 2.10.X version release labels Dec 15, 2024
@Efnilite Efnilite added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 18, 2024
@Moderocky Moderocky merged commit 3e8b011 into SkriptLang:dev/feature Dec 18, 2024
5 checks passed
@ShaneBeee ShaneBeee deleted the feature/default-comparators branch December 18, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.10 Targeting a 2.10.X version release bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants