Public API Keys #140
Merged
Public API Keys #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More tests are needed.
# Conflicts: # test/tester.go
# Conflicts: # api/handlers.go
…ciently different from the general (secret) API keys.
…eys - `GET /user/limits/:skylink`.
…re the cached value.
# Conflicts: # api/cache.go # api/cache_test.go # api/handlers.go # api/routes.go # database/apikeys.go # test/api/api_test.go # test/api/handlers_test.go
peterjan
reviewed
Mar 11, 2022
peterjan
reviewed
Mar 11, 2022
peterjan
reviewed
Mar 11, 2022
peterjan
requested changes
Mar 11, 2022
Co-authored-by: Peter-Jan Brone <peter-jan@settlemint.com>
Co-authored-by: Peter-Jan Brone <peter-jan@settlemint.com>
Co-authored-by: Peter-Jan Brone <peter-jan@settlemint.com>
# Conflicts: # database/upload.go
Cover other PR comments.
# Conflicts: # api/handlers.go # test/api/api_test.go # test/api/handlers_test.go # test/tester.go
ChrisSchinnerl
approved these changes
Mar 18, 2022
peterjan
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
Public API keys are a special type of API keys which are meant to be shared with the public. Their validity is very limited - they only allow users to download skylinks and even that is limited to a pre-determined list of skylinks.
The main questions in this PR are:
Currently open TODOs:
auth.goExample for Visual Changes
Checklist
Review and complete the checklist to ensure that the PR is complete before assigned to an approver.
Issues Closed