Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the Tester package #152

Merged
merged 13 commits into from
Apr 5, 2022
Merged

Refactor the Tester package #152

merged 13 commits into from
Apr 5, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Mar 15, 2022 •
edited
Loading

PULL REQUEST

Overview

The Tester package has room for improvement and PJ had some good input:

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

@ro-tex ro-tex self-assigned this Mar 15, 2022
@ro-tex ro-tex mentioned this pull request Mar 15, 2022
Merged
5 tasks
@ro-tex ro-tex marked this pull request as ready for review March 28, 2022 15:32
ChrisSchinnerl
ChrisSchinnerl reviewed Mar 31, 2022
View reviewed changes
test/tester_test.go Outdated Show resolved Hide resolved
test/api/challenge_test.go Show resolved Hide resolved
test/tester.go Outdated Show resolved Hide resolved
test/tester.go Outdated Show resolved Hide resolved
@ro-tex ro-tex enabled auto-merge April 5, 2022 09:44
@ro-tex ro-tex mentioned this pull request Apr 5, 2022
Closed
@ro-tex ro-tex merged commit 1cfa6db into main Apr 5, 2022
@ro-tex ro-tex deleted the ivo/refactor_tester branch April 5, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjan peterjan peterjan approved these changes

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

Assignees

@ro-tex ro-tex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ro-tex @peterjan @ChrisSchinnerl