Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] A collection of minto follow up actions #170

Merged
merged 8 commits into from
Mar 31, 2022
Merged

[MINOR] A collection of minto follow up actions #170

merged 8 commits into from
Mar 31, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Mar 24, 2022

PULL REQUEST

Overview

This PR started as a branch for one minor follow up and a couple more were added.
The only change that leads to behaviour change is the omitempty annotations to APIKeyPOST.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

@ro-tex ro-tex self-assigned this Mar 24, 2022
@ro-tex ro-tex mentioned this pull request Mar 25, 2022
5 tasks
@ro-tex ro-tex marked this pull request as ready for review March 30, 2022 11:10
@ro-tex ro-tex requested review from peterjan, ChrisSchinnerl, MSevey and mrcnski and removed request for MSevey March 30, 2022 11:11
@ro-tex ro-tex changed the title [MINOR] [MINOR] A collection of minto follow up actions Mar 30, 2022
@ro-tex ro-tex merged commit fa3b256 into main Mar 31, 2022
@ro-tex ro-tex deleted the ivo/minor branch March 31, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants