Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Do not allow passing both dev and alpha options for MySky #257

Closed
mrcnski opened this issue Aug 18, 2021 · 2 comments
Closed

Do not allow passing both dev and alpha options for MySky #257

mrcnski opened this issue Aug 18, 2021 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Aug 18, 2021

Setting both should not be allowed. One sends you to the URL for alpha MySky and the other to dev MySky at a different URL. They are incompatible so if you try passing both it should be an error.
@mrcnski mrcnski added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 18, 2021
@mrcnski mrcnski self-assigned this Aug 18, 2021
@mrcnski mrcnski mentioned this issue Aug 18, 2021
Merged
@mrcnski
Copy link
Contributor Author

mrcnski commented Aug 18, 2021 •
edited
Loading

Background: #254 (comment)

@mrcnski mrcnski removed their assignment Oct 5, 2021
AmberMichaelis added a commit to AmberMichaelis/skynet-js that referenced this issue Dec 3, 2021
@AmberMichaelis
Prevents trying to pass both dev and alpha options for MySky SkynetLa…
8b75365 
…bs#257
AmberMichaelis added a commit to AmberMichaelis/skynet-js that referenced this issue Dec 3, 2021
@AmberMichaelis
Throws error when passing both dev and alpha options for MySky (Skyne…
803e88e 
…tLabs#257)
@AmberMichaelis AmberMichaelis mentioned this issue Dec 3, 2021
Merged
mrcnski added a commit that referenced this issue Mar 7, 2022
@mrcnski
Merge pull request #352 from amberm31/alpha_dev
9012adb 
Throws error when passing both dev and alpha options for MySky (#257).
@kwypchlo
Copy link
Collaborator

closed by #352

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwypchlo @mrcnski