Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Throws error when passing both dev and alpha options for MySky (#257). #352

Merged
merged 4 commits into from
Mar 7, 2022

Conversation

AmberMichaelis
Copy link
Contributor

PULL REQUEST

Overview

Added an if statement to throw an error if both opts.alpha and opts.dev are set.

Issues Closed

#257

mrcnski
mrcnski previously approved these changes Dec 3, 2021
Copy link
Contributor

@mrcnski mrcnski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Approved, but feel free to make the suggested change and I can re-approve.

src/mysky/index.ts Outdated Show resolved Hide resolved
AmberMichaelis and others added 2 commits December 3, 2021 14:30
@@ -3,3 +3,4 @@ node_modules
dist
yarn-error.log
coverage
.vscode

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit add newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make this change when I have time.

@mrcnski mrcnski merged commit 9012adb into SkynetLabs:master Mar 7, 2022
@AmberMichaelis AmberMichaelis deleted the alpha_dev branch May 19, 2022 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants