fix bug on HTML tree #561
Merged
fix bug on HTML tree #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 3e28191 in 34 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_bZXCAMNLzqE3LYFv
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -96,7 +96,7 @@ def json_to_html(element: dict) -> str: | |||
| ) | |||
|
|
|||
| # Check if the element is self-closing | |||
| if tag in ["img", "input", "br", "hr", "meta", "link"]: | |||
| if tag in ["img", "input", "br", "hr", "meta", "link"] and not option_html and not children_html: | |||
There was a problem hiding this comment.
The condition for adding space before attributes_html is redundant and can be simplified. Consider revising it to ensure correct spacing only when attributes_html is not empty.
Suggested change
| if tag in ["img", "input", "br", "hr", "meta", "link"] and not option_html and not children_html: | |
| return f'<{tag}{" "+attributes_html if attributes_html else ""}>' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixed self-closing tag logic in
json_to_htmlfunction to correctly handleoption_htmlandchildren_htmlcontent.Key points:
skyvern/webeye/scraper/scraper.pyjson_to_htmloption_htmlandchildren_html.img,input,br,hr,meta, andlinkwill only be self-closed if they have nooption_htmlorchildren_htmlcontent.Generated with ❤️ by ellipsis.dev