Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug on HTML tree #561

Merged
merged 1 commit into from
Jul 6, 2024
Merged

fix bug on HTML tree #561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skyvern/webeye/scraper/scraper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def json_to_html(element: dict) -> str:
)

# Check if the element is self-closing
if tag in ["img", "input", "br", "hr", "meta", "link"]:
if tag in ["img", "input", "br", "hr", "meta", "link"] and not option_html and not children_html:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition for adding space before attributes_html is redundant and can be simplified. Consider revising it to ensure correct spacing only when attributes_html is not empty.

Suggested change
if tag in ["img", "input", "br", "hr", "meta", "link"] and not option_html and not children_html:
return f'<{tag}{" "+attributes_html if attributes_html else ""}>'

return f'<{tag}{attributes_html if not attributes_html else " "+attributes_html}>'
else:
return f'<{tag}{attributes_html if not attributes_html else " "+attributes_html}>{text}{children_html+option_html}</{tag}>'
Expand Down
Loading