remove browser init injection #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d361b30 in 9 seconds
More details
- Looked at
23lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/webeye/browser_factory.py:112
- Draft comment:
Ensure that removing the PDF printer disabling script aligns with system requirements, as it might affect functionality if still needed elsewhere. - Reason this comment was not posted:
Confidence changes required:50%
The removal of the line that disables the PDF printer might have implications if the functionality is still required elsewhere. It's important to ensure that this change aligns with the overall system requirements.
Workflow ID: wflow_KrKgSoBDcspsNuj0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Removed PDF printer disabling script from browser context initialization in
skyvern/webeye/browser_factory.py.Key points:
DISABLE_PRINTER_WITH_FLAGimport fromskyvern/webeye/browser_factory.py.await browser_context.add_init_script(DISABLE_PRINTER_WITH_FLAG)fromcreate_browser_contextfunction.Generated with ❤️ by ellipsis.dev