Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove browser init injection #742

Merged
merged 1 commit into from
Aug 27, 2024
Merged

remove browser init injection #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions skyvern/webeye/browser_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
from skyvern.forge.sdk.core.skyvern_context import current
from skyvern.forge.sdk.schemas.tasks import ProxyLocation
from skyvern.forge.sdk.settings_manager import SettingsManager
from skyvern.webeye.utils.page import DISABLE_PRINTER_WITH_FLAG, SkyvernFrame
from skyvern.webeye.utils.page import SkyvernFrame

LOG = structlog.get_logger()

Expand Down Expand Up @@ -110,8 +110,6 @@ async def create_browser_context(
if not creator:
raise UnknownBrowserType(browser_type)
browser_context, browser_artifacts, cleanup_func = await creator(playwright, **kwargs)
# overwrite the window.print() to disable the PDF printer
await browser_context.add_init_script(DISABLE_PRINTER_WITH_FLAG)
return browser_context, browser_artifacts, cleanup_func
except UnknownBrowserType as e:
raise e
Expand Down
Loading