-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto filter deleted parameters from parameter_keys #819
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit d893ec0d6e77410d3255715d2dc1599c92c24b92 | |--------|--------| fix: auto-filter deleted parameters from `parameterKeys` in task nodes ### Summary: Update `WorkflowParametersPanel` to auto-filter deleted parameters and add utility for `nodeAdder` identification. **Key points**: - **Behavior**: Deleting a parameter removes it from `parameterKeys` in `task` nodes; editing updates `parameterKeys` with the new key. - **Utilities**: Add `isNodeAdderNode()` to identify `nodeAdder` nodes. - **Types**: Change `NodeAdderNodeData` type to `Record<string, unknown>` to allow unknown properties. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 87322d6 in 26 seconds
More details
- Looked at
127
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx:1
- Draft comment:
Organize import statements by grouping and ordering them logically, such as third-party imports first, followed by local imports. - Reason this comment was not posted:
Confidence changes required:50%
The import statements inFlowRenderer.tsx
are not organized properly. They should be grouped and ordered logically, such as third-party imports first, followed by local imports.
2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParametersPanel.tsx:147
- Draft comment:
Consider refactoring the logic for updating nodes when parameters are deleted or edited into a separate function to avoid code duplication. This logic is repeated in the delete and edit operations. - Reason this comment was not posted:
Confidence changes required:50%
ThesetNodes
function is used twice inWorkflowParametersPanel.tsx
to update nodes when parameters are deleted or edited. This logic is duplicated and could be refactored into a separate function to improve code maintainability.
Workflow ID: wflow_OJS27CNEcF99XqFz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 87322d6 in 40 seconds
More details
- Looked at
126
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx:1
- Draft comment:
Organize import statements by grouping them logically and ordering them alphabetically within each group for better readability. - Reason this comment was not posted:
Confidence changes required:10%
The import statements inFlowRenderer.tsx
are not organized properly. They should be grouped and ordered logically for better readability and maintainability.
2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParametersPanel.tsx:144
- Draft comment:
Good use ofsetNodes
to update nodes when parameters are deleted, ensuring consistency between parameters and nodes. This pattern is repeated for editing parameters as well. - Reason this comment was not posted:
Confidence changes required:0%
ThesetNodes
function is used twice inWorkflowParametersPanel.tsx
to update nodes when parameters are deleted or edited. This is a good practice to ensure consistency between parameters and nodes.
Workflow ID: wflow_P2qwQdORDlBhbU3L
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
fix: auto-filter deleted parameters from
parameterKeys
in task nodesSummary:
Update
WorkflowParametersPanel
to auto-filter deleted parameters and add utility for node identification.Key points:
parameterKeys
intask
nodes; editing updatesparameterKeys
with the new key.isNodeAdderNode()
to identifynodeAdder
nodes.NodeAdderNodeData
type toRecord<string, unknown>
to allow unknown properties.Generated with ❤️ by ellipsis.dev