Auto filter deleted parameters from parameter_keys

[ykeremy]

🚀	This description was created by Ellipsis for commit 87322d6

fix: auto-filter deleted parameters from parameterKeys in task nodes

Summary:

Update WorkflowParametersPanel to auto-filter deleted parameters and add utility for node identification.

Key points:

• Behavior: Deleting a parameter removes it from parameterKeys in task nodes; editing updates parameterKeys with the new key.
• Utilities: Add isNodeAdderNode() to identify nodeAdder nodes.
• Types: Change NodeAdderNodeData type to Record<string, unknown> to allow unknown properties.

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 87322d6 in 26 seconds

More details

• Looked at 127 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx:1

• Draft comment:
  Organize import statements by grouping and ordering them logically, such as third-party imports first, followed by local imports.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The import statements in FlowRenderer.tsx are not organized properly. They should be grouped and ordered logically, such as third-party imports first, followed by local imports.

2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParametersPanel.tsx:147

• Draft comment:
  Consider refactoring the logic for updating nodes when parameters are deleted or edited into a separate function to avoid code duplication. This logic is repeated in the delete and edit operations.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The setNodes function is used twice in WorkflowParametersPanel.tsx to update nodes when parameters are deleted or edited. This logic is duplicated and could be refactored into a separate function to improve code maintainability.

Workflow ID: wflow_OJS27CNEcF99XqFz

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 87322d6 in 40 seconds

More details

• Looked at 126 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx:1

• Draft comment:
  Organize import statements by grouping them logically and ordering them alphabetically within each group for better readability.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The import statements in FlowRenderer.tsx are not organized properly. They should be grouped and ordered logically for better readability and maintainability.

2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParametersPanel.tsx:144

• Draft comment:
  Good use of setNodes to update nodes when parameters are deleted, ensuring consistency between parameters and nodes. This pattern is repeated for editing parameters as well.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The setNodes function is used twice in WorkflowParametersPanel.tsx to update nodes when parameters are deleted or edited. This is a good practice to ensure consistency between parameters and nodes.

Workflow ID: wflow_P2qwQdORDlBhbU3L

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.