use registered_domain to search in bitwarden #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 2946cda in 10 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/services/bitwarden.py:161
- Draft comment:
The change to useregistered_domaininstead ofdomainis correct and improves precision in domain extraction for Bitwarden searches. - Reason this comment was not posted:
Confidence changes required:0%
The change from extracting the domain to extracting the registered domain is correct and aligns with the intent to search for items in Bitwarden using the registered domain. This is a more precise approach for identifying the domain associated with the URL.
Workflow ID: wflow_mPeXdTXKlVPve2ZB
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
ykeremy
approved these changes
Oct 8, 2024
suchintan
reviewed
Oct 8, 2024
| # Extract the domain from the URL and search for items in Bitwarden with that domain | ||
| domain = tldextract.extract(url).domain | ||
| # Extract the domain(with suffix) from the URL and search for items in Bitwarden with that domain | ||
| domain = tldextract.extract(url).registered_domain |
There was a problem hiding this comment.
can we fall back to the domain if the registered_domain search doesn't return anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Change domain extraction in
bitwarden.pyto useregistered_domainfor Bitwarden searches.bitwarden.py, change domain extraction in_get_secret_value_from_url()fromdomaintoregistered_domainusingtldextract.This description was created by
for 2946cda. It will automatically update as commits are pushed.