Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use registered_domain to search in bitwarden #929

Merged
merged 2 commits into from
Oct 8, 2024
Merged

use registered_domain to search in bitwarden #929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cd53e4
use registered_domain to search in bitwarden
LawyZheng Oct 8, 2024
2946cda
use registered_domain to search in bitwarden
LawyZheng Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions skyvern/forge/sdk/services/bitwarden.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,8 @@ async def _get_secret_value_from_url(
BitwardenService.sync()
session_key = BitwardenService.unlock(master_password)

# Extract the domain from the URL and search for items in Bitwarden with that domain
domain = tldextract.extract(url).domain
# Extract the domain(with suffix) from the URL and search for items in Bitwarden with that domain
domain = tldextract.extract(url).registered_domain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we fall back to the domain if the registered_domain search doesn't return anything?

list_command = [
"bw",
"list",
Expand Down
Loading