Implement xdg-foreign protocol #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i509VCB
changed the title
i509VCB
force-pushed
the
xdg-foreign
branch
2 times, most recently
from
3d8277b to
958219e
Compare
i509VCB
changed the title
elinorbgr
requested changes
Jul 25, 2021
|
@vberger I think I've resolved your requests here. |
|
Hmm, so, seen how you changed your PR, it looks like you missed the fact that there are two different roles Taking that into account, I don't think it's necessarily a good idea to move one of them in |
|
Hmm I probably need to make sure I did fully implement the wl_shell_surface parent logic |
elinorbgr
reviewed
Jul 27, 2021
elinorbgr
reviewed
Jul 27, 2021
i509VCB
force-pushed
the
xdg-foreign
branch
2 times, most recently
from
e2be507 to
287aee1
Compare
Merged
elinorbgr
requested changes
Jul 30, 2021
i509VCB
force-pushed
the
xdg-foreign
branch
2 times, most recently
from
2dcc6fa to
26e3746
Compare
This is very much incomplete, but it implements the import and export of surfaces. However functions related to setting and imported surface the parent of another surface is not done. importer destructor destroys all imports made from the same client Implement SetParentOf, no undoing yet Add inner import type Destroy child surface relationships when importing A note move init function upwards use 0.29.0 crate Move role string constants into the public Use toplevel_like for surface checks in foreign add methods to get the parent surface Make sure ZXDG roles are public api Consistent ordering of parameters on xdg_foreign impl methods Let's update the changelog Document how to use xdg_foreign wl_shell_surface is likely invalid, so it cannot be imported or exported Changelog suggestions remove redundant inner ref cell Remove all uses of the refcell like behavior Allow compositor to export surfaces on server Appease new clippy lints then Use string references and iterate in reverse to simplify removals heed request for order
elinorbgr
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the xdg-foreign protocol. This allows a client to export a surface and then allow another import the surface using a handle.
So what's needed otherwise: