WLR Layer Shell Support #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolyMeilex
force-pushed
the
layer-v3
branch
2 times, most recently
from
0f59837 to
041ac1e
Compare
elinorbgr
requested changes
Jul 30, 2021
|
So, a few minor points, mostly regarding documentation. Other than that this looks pretty solid, thank! 👍 Also, could you rebase on master, to run the new CI? |
|
All long lines got eradicated. While at it, I also exposed the surface role |
i509VCB
reviewed
Jul 31, 2021
elinorbgr
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design goal of this implementation was to make its API as similar to
xdg-shellas possible, the idea is that if someone already knows how to usexdg-shellthey should be able to start usinglayer-shellby using nearly the same API. SoCachedState,with_pending_state,current_state, etc. are all there, and should act just like xdg equivalents.Anvil implementation of layer shell is lacking at the moment, I wanted to implement everything but the more I added, the hackier the code felt, so I decided to stop. The main missing piece for anvil is exclusive_zone support, but I think that I implemented enough to make it a useful test ground for future changes.
anodium-7.mp4