feat: Account v1 readiness #3236

sfc-gh-jcieslak · 2024-11-28T10:26:22Z

Changes

Adjust SDK to be up-to-date with Snowflake capabilities
Update unit and integration tests
Adjust the setup_test.go for integration tests, so it works for clients that have orgadmin role (and accountadmin)

Questions

Do we want to use AccountIdentifier instead of AccountObjectIdentifier in Account object? I was sceptic because mostly everywhere the account name is sufficient. I can check if orgname is also acceptable and adjust the identifier to AccountIdentifier one.
What do we want to do with test that requires moving account between organizations?

Others

I'll report the error with polaris, as I was unable to create an account with polaris set to true.

Next prs (in order)

Next pr: Re-generating all assertions, schema mappings, etc.
Next pr: Adjusting existing resource and data source.
...

gitguardian · 2024-11-28T10:26:26Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

github-actions · 2024-11-28T10:37:59Z

Integration tests cancelled for 31c6e5b14d1d3a15d02abeffa598d5d0ae479c17

github-actions · 2024-12-02T14:57:35Z

Integration tests failure for 461511ed303f0fc0b9adb5792b315d0c39865432

github-actions · 2024-12-02T15:51:50Z

Integration tests cancelled for 7e6b8a387651c4f36b5cbf92945f35e6ad6d15b3

github-actions · 2024-12-02T17:40:11Z

Integration tests failure for 6d75c932db7dd08c531764900d2a9ce51d93f78b

github-actions · 2024-12-02T18:19:18Z

Integration tests failure for 530aa0df86d992e1c37255a5e750ed17245637c4

pkg/acceptance/helpers/account_client.go

pkg/acceptance/helpers/packages_policy_client.go

pkg/sdk/testint/accounts_integration_test.go

pkg/acceptance/helpers/account_client.go

pkg/acceptance/helpers/random/certs.go

pkg/sdk/testint/setup_test.go

pkg/sdk/testint/accounts_integration_test.go

pkg/acceptance/helpers/account_client.go

pkg/sdk/testint/accounts_integration_test.go

github-actions · 2024-12-04T12:24:39Z

Integration tests failure for 41fa92f6f320611541faf4b141248f2fb3b56fb8

github-actions · 2024-12-05T09:42:05Z

Integration tests failure for 55f0c6fbd304092092bcfb8076e755dd007ac01b

sfc-gh-asawicki · 2024-12-05T10:29:29Z

pkg/acceptance/helpers/account_client.go

@@ -92,6 +84,32 @@ func (c *AccountClient) Alter(t *testing.T, opts *sdk.AlterAccountOptions) {
 	require.NoError(t, err)
 }

+func (c *AccountClient) UnsetPoliciesFunc(t *testing.T) func() {


this method is dangerous because it can alter the "wrong" account. We should at least have some safeguards (for now).

As discussed SelfAlter tests for account are skipped. For now it's pointing to the general ticket (but mentioned it explicitly in the acc criteria).

github-actions · 2024-12-05T14:44:23Z

Integration tests failure for 8b51f4982463a11dd7814dab87d4bb1d2722da0e

🤖 I have created a release *beep* *boop* --- ## [0.100.0](v0.99.0...v0.100.0) (2024-12-12) ### 🎉 **What's new:** * Account v1 readiness ([#3236](#3236)) ([5df33a8](5df33a8)) * Account v1 readiness generated files ([#3242](#3242)) ([3df59dd](3df59dd)) * Account v1 readiness resource ([#3252](#3252)) ([8f5698d](8f5698d)) * Add a new account roles data source ([#3257](#3257)) ([b3d6b9e](b3d6b9e)) * Add account data source ([#3261](#3261)) ([6087fc9](6087fc9)) * Add all other functions and procedures implementations ([#3275](#3275)) ([7a6f68d](7a6f68d)) * Basic functions implementation ([#3269](#3269)) ([6d4a103](6d4a103)) * Basic procedures implementation ([#3271](#3271)) ([933335f](933335f)) * Docs, test, and missing parameter ([#3280](#3280)) ([10517f3](10517f3)) * Functions and procedures schemas and generated sources ([#3262](#3262)) ([9b70f87](9b70f87)) * Functions sdk update ([#3254](#3254)) ([fc1eace](fc1eace)) * Handle missing fields in function and procedure ([#3273](#3273)) ([53e7a0a](53e7a0a)) * Procedures schemas and generated sources ([#3263](#3263)) ([211ad46](211ad46)) * Procedures sdk update ([#3255](#3255)) ([682606a](682606a)) * Rework account parameter resource ([#3264](#3264)) ([15aa9c2](15aa9c2)) * Rework data types ([#3244](#3244)) ([05ada91](05ada91)) * support table data type ([#3274](#3274)) ([13401d5](13401d5)) * Tag association v1 readiness ([#3210](#3210)) ([04f6d54](04f6d54)) * Test imports and small fixes ([#3276](#3276)) ([a712195](a712195)) * Unsafe execute v1 readiness ([#3266](#3266)) ([c4f1e8f](c4f1e8f)) * Use new data types in sql builder for functions and procedures ([#3247](#3247)) ([69f677a](69f677a)) ### 🔧 **Misc** * Add ShowByID filtering generation ([#3227](#3227)) ([548ec42](548ec42)) * Adress small task-related todos ([#3243](#3243)) ([40de9ae](40de9ae)) * Apply masking ([#3234](#3234)) ([c209a8a](c209a8a)) * fix missing references in toOpts and changes with newlines ([#3240](#3240)) ([246547f](246547f)) * function tests ([#3279](#3279)) ([5af6efb](5af6efb)) * Improve config builders ([#3207](#3207)) ([425787c](425787c)) * Revert to proper env ([#3238](#3238)) ([5d4ed3b](5d4ed3b)) * Use service user for ci ([#3228](#3228)) ([2fb50d7](2fb50d7)) ### 🐛 **Bug fixes:** * Make blocked_roles_field optional in OAuth security integrations ([#3267](#3267)) ([7197b57](7197b57)) * Minor fixes ([#3231](#3231)) ([1863bf6](1863bf6)) * Minor fixes 2 ([#3230](#3230)) ([73b7e74](73b7e74)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>

sfc-gh-jcieslak marked this pull request as draft November 28, 2024 10:37

sfc-gh-jcieslak added 5 commits December 2, 2024 15:54

wip

7dfda5f

wip

c299672

wip

15ad29a

wip

de39050

wip

461511e

sfc-gh-jcieslak force-pushed the account-v1-readiness branch from bd5e085 to 461511e Compare December 2, 2024 14:54

sfc-gh-jcieslak added 3 commits December 2, 2024 16:22

wip

6d75c93

wip

7e6b8a3

fix tests

530aa0d

sfc-gh-jcieslak marked this pull request as ready for review December 3, 2024 06:48

sfc-gh-jmichalak requested changes Dec 3, 2024

View reviewed changes

sfc-gh-asawicki self-requested a review December 3, 2024 15:34

sfc-gh-asawicki requested changes Dec 3, 2024

View reviewed changes

changes after review

41fa92f

Fix test

55f0c6f

sfc-gh-asawicki self-requested a review December 5, 2024 09:45

sfc-gh-jmichalak previously approved these changes Dec 5, 2024

View reviewed changes

sfc-gh-asawicki requested changes Dec 5, 2024

View reviewed changes

changes after review

8b51f49

sfc-gh-jcieslak dismissed sfc-gh-jmichalak’s stale review via 8b51f49 December 5, 2024 12:27

sfc-gh-jcieslak requested a review from sfc-gh-asawicki December 5, 2024 12:28

sfc-gh-jcieslak requested a review from sfc-gh-jmichalak December 5, 2024 12:28

sfc-gh-jmichalak approved these changes Dec 5, 2024

View reviewed changes

sfc-gh-asawicki approved these changes Dec 5, 2024

View reviewed changes

sfc-gh-jcieslak merged commit 5df33a8 into main Dec 6, 2024
8 of 9 checks passed

sfc-gh-jcieslak deleted the account-v1-readiness branch December 6, 2024 07:15

snowflake-release-please bot mentioned this pull request Dec 5, 2024

chore(main): release 0.100.0 #3237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Account v1 readiness #3236

feat: Account v1 readiness #3236

sfc-gh-jcieslak commented Nov 28, 2024 •

edited

Loading

gitguardian bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 28, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 5, 2024

sfc-gh-asawicki Dec 5, 2024

sfc-gh-jcieslak Dec 5, 2024

github-actions bot commented Dec 5, 2024

feat: Account v1 readiness #3236

feat: Account v1 readiness #3236

Conversation

sfc-gh-jcieslak commented Nov 28, 2024 • edited Loading

Changes

Questions

Others

Next prs (in order)

gitguardian bot commented Nov 28, 2024 • edited Loading

️✅ There are no secrets present in this pull request anymore.

github-actions bot commented Nov 28, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 4, 2024

github-actions bot commented Dec 5, 2024

sfc-gh-asawicki Dec 5, 2024

Choose a reason for hiding this comment

sfc-gh-jcieslak Dec 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2024

sfc-gh-jcieslak commented Nov 28, 2024 •

edited

Loading

gitguardian bot commented Nov 28, 2024 •

edited

Loading