Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix missing references in toOpts and changes with newlines #3240

Merged
merged 13 commits into from
Dec 9, 2024
Merged

chore: fix missing references in toOpts and changes with newlines #3240

merged 13 commits into from
Dec 9, 2024

Conversation

sfc-gh-fbudzynski
Copy link
Collaborator

@sfc-gh-fbudzynski sfc-gh-fbudzynski commented Dec 2, 2024 •
edited
Loading

Changes

  • fixed issue with newlines in _impl file
  • fixed issue with missing reference operators in toOpts functions
  • fixed issue with no newline between helper structs for implementation file

Notes

  • generated an example with optional and non-optional queryStructs to showcase the generation now handles optional and non-optional structs respectively

@sfc-gh-fbudzynski sfc-gh-fbudzynski changed the title Sdk fix missing references chore: fix missing references in toOpts and changes with newlines Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Integration tests failure for a3961d548f1e5c1c1d5ab3a150a162e810d732ff

@sfc-gh-fbudzynski sfc-gh-fbudzynski marked this pull request as ready for review December 2, 2024 13:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Integration tests failure for 17469b580f4416e17688faf0f11ef980f0e27b53

sfc-gh-jcieslak
sfc-gh-jcieslak previously approved these changes Dec 5, 2024
View reviewed changes
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review December 5, 2024 09:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Integration tests failure for 3ac22fda4dffa5f48b2cadef01eda37ef13b64de

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Integration tests failure for 613763278a5bceeb9fd8a12fcdaf70f4b17c1848

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Integration tests failure for d37fd13fe2e204f4fdb44d58247d1ad0e694ddc1

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Integration tests failure for 96ac7365da6828ebe264cfeadfc27af6f0874f28

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Integration tests failure for 93dc7fa101c92ce822c2e42ea66520ab57d7eeba

@sfc-gh-fbudzynski sfc-gh-fbudzynski merged commit 246547f into main Dec 9, 2024
9 of 10 checks passed
@sfc-gh-fbudzynski sfc-gh-fbudzynski deleted the sdk-fix-missing-references branch December 9, 2024 09:17
@snowflake-release-please snowflake-release-please bot mentioned this pull request Dec 9, 2024
Merged
@sfc-gh-fbudzynski sfc-gh-fbudzynski mentioned this pull request Dec 9, 2024
Merged
sfc-gh-jcieslak pushed a commit that referenced this pull request Dec 12, 2024
@snowflake-release-please
chore(main): release 0.100.0 (#3237)
5139b1a 
🤖 I have created a release *beep* *boop*
---


##
[0.100.0](v0.99.0...v0.100.0)
(2024-12-12)


### 🎉 **What's new:**

* Account v1 readiness
([#3236](#3236))
([5df33a8](5df33a8))
* Account v1 readiness generated files
([#3242](#3242))
([3df59dd](3df59dd))
* Account v1 readiness resource
([#3252](#3252))
([8f5698d](8f5698d))
* Add a new account roles data source
([#3257](#3257))
([b3d6b9e](b3d6b9e))
* Add account data source
([#3261](#3261))
([6087fc9](6087fc9))
* Add all other functions and procedures implementations
([#3275](#3275))
([7a6f68d](7a6f68d))
* Basic functions implementation
([#3269](#3269))
([6d4a103](6d4a103))
* Basic procedures implementation
([#3271](#3271))
([933335f](933335f))
* Docs, test, and missing parameter
([#3280](#3280))
([10517f3](10517f3))
* Functions and procedures schemas and generated sources
([#3262](#3262))
([9b70f87](9b70f87))
* Functions sdk update
([#3254](#3254))
([fc1eace](fc1eace))
* Handle missing fields in function and procedure
([#3273](#3273))
([53e7a0a](53e7a0a))
* Procedures schemas and generated sources
([#3263](#3263))
([211ad46](211ad46))
* Procedures sdk update
([#3255](#3255))
([682606a](682606a))
* Rework account parameter resource
([#3264](#3264))
([15aa9c2](15aa9c2))
* Rework data types
([#3244](#3244))
([05ada91](05ada91))
* support table data type
([#3274](#3274))
([13401d5](13401d5))
* Tag association v1 readiness
([#3210](#3210))
([04f6d54](04f6d54))
* Test imports and small fixes
([#3276](#3276))
([a712195](a712195))
* Unsafe execute v1 readiness
([#3266](#3266))
([c4f1e8f](c4f1e8f))
* Use new data types in sql builder for functions and procedures
([#3247](#3247))
([69f677a](69f677a))


### 🔧 **Misc**

* Add ShowByID filtering generation
([#3227](#3227))
([548ec42](548ec42))
* Adress small task-related todos
([#3243](#3243))
([40de9ae](40de9ae))
* Apply masking
([#3234](#3234))
([c209a8a](c209a8a))
* fix missing references in toOpts and changes with newlines
([#3240](#3240))
([246547f](246547f))
* function tests
([#3279](#3279))
([5af6efb](5af6efb))
* Improve config builders
([#3207](#3207))
([425787c](425787c))
* Revert to proper env
([#3238](#3238))
([5d4ed3b](5d4ed3b))
* Use service user for ci
([#3228](#3228))
([2fb50d7](2fb50d7))


### 🐛 **Bug fixes:**

* Make blocked_roles_field optional in OAuth security integrations
([#3267](#3267))
([7197b57](7197b57))
* Minor fixes
([#3231](#3231))
([1863bf6](1863bf6))
* Minor fixes 2
([#3230](#3230))
([73b7e74](73b7e74))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
sfc-gh-fbudzynski added a commit that referenced this pull request Dec 16, 2024
@sfc-gh-fbudzynski
chore: remove generating integration tests placeholder file (#3256)
a16de3f 
<!-- Feel free to delete comments as you fill this in -->

<!-- summary of changes -->
## Changes
- removed generation of integration_tests file
- added a print for the user to create the integration tests manually
- changed the `ShowByIdOperation` name to `ShowByIdOperationNoFiltering`
for no automatic generation of filtering options
- adjusted the template for ShowByID filtering
- removed `ShowByIDNoFiltering` option (replaced by
`ShowByIdOperationNoFiltering`)
- adjusted README of the SDK generator to the current state 

## References
<!-- issues documentation links, etc  -->
*
#3227
*
#3240
sfc-gh-asawicki pushed a commit that referenced this pull request Dec 20, 2024
@sfc-gh-fbudzynski @sfc-gh-asawicki
chore: remove generating integration tests placeholder file (#3256)
e0ed15b 
<!-- Feel free to delete comments as you fill this in -->

<!-- summary of changes -->
## Changes
- removed generation of integration_tests file
- added a print for the user to create the integration tests manually
- changed the `ShowByIdOperation` name to `ShowByIdOperationNoFiltering`
for no automatic generation of filtering options
- adjusted the template for ShowByID filtering
- removed `ShowByIDNoFiltering` option (replaced by
`ShowByIdOperationNoFiltering`)
- adjusted README of the SDK generator to the current state 

## References
<!-- issues documentation links, etc  -->
*
#3227
*
#3240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak Awaiting requested review from sfc-gh-jcieslak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-fbudzynski @sfc-gh-jcieslak @sfc-gh-asawicki @sfc-gh-jmichalak