Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a new account roles data source #3257

Merged
merged 11 commits into from
Dec 12, 2024

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

  • add a new data source for account rolers to be consistent with resources
  • prove that database role with the same prefix is not in the output of SHOW ROLES
  • deprecate the roles data source (it will be removed in v1-ready branch)

Test Plan

  • acceptance tests

References

https://docs.snowflake.com/en/sql-reference/sql/show-roles

Copy link

github-actions bot commented Dec 9, 2024

Integration tests failure for 1389a0b146d2a0d433edff04a6d1bcba845df521

@sfc-gh-jmichalak sfc-gh-jmichalak marked this pull request as ready for review December 10, 2024 09:12
docs/data-sources/account_roles.md Outdated Show resolved Hide resolved
pkg/datasources/account_roles.go Outdated Show resolved Hide resolved
pkg/datasources/account_roles.go Outdated Show resolved Hide resolved
pkg/datasources/account_roles.go Outdated Show resolved Hide resolved
pkg/datasources/account_roles.go Outdated Show resolved Hide resolved
Copy link

Integration tests cancelled for 9e4608faa6e51755176b30fcb99c97d6fc9dc5a6

Copy link

Integration tests failure for 3892f0b8e72156266226b28e3d2506faf066abd3

Copy link

Integration tests failure for 91e06ff36af1f86c5d831051efecac3173e8e72c

Copy link

Integration tests failure for 91e06ff36af1f86c5d831051efecac3173e8e72c

Copy link

Integration tests failure for da06fc9ad4e87c875f2e9fc601d6dbffdd743308

Copy link

Integration tests cancelled for 237dc5211fa5ce2f0baff877c8e543d5b2d5e6f2

Copy link

Integration tests cancelled for c67f170d27ef4aa1e98babe59e06c0e36903068a

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review December 12, 2024 14:22
Copy link

Integration tests cancelled for 5f6933c3bf130430a1b52c025c0e5c3abe5203d1

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review December 12, 2024 14:50
@sfc-gh-jmichalak sfc-gh-jmichalak merged commit b3d6b9e into main Dec 12, 2024
8 of 9 checks passed
@sfc-gh-jmichalak sfc-gh-jmichalak deleted the rename-roles-data-source branch December 12, 2024 15:17
sfc-gh-jcieslak pushed a commit that referenced this pull request Dec 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.100.0](v0.99.0...v0.100.0)
(2024-12-12)


### 🎉 **What's new:**

* Account v1 readiness
([#3236](#3236))
([5df33a8](5df33a8))
* Account v1 readiness generated files
([#3242](#3242))
([3df59dd](3df59dd))
* Account v1 readiness resource
([#3252](#3252))
([8f5698d](8f5698d))
* Add a new account roles data source
([#3257](#3257))
([b3d6b9e](b3d6b9e))
* Add account data source
([#3261](#3261))
([6087fc9](6087fc9))
* Add all other functions and procedures implementations
([#3275](#3275))
([7a6f68d](7a6f68d))
* Basic functions implementation
([#3269](#3269))
([6d4a103](6d4a103))
* Basic procedures implementation
([#3271](#3271))
([933335f](933335f))
* Docs, test, and missing parameter
([#3280](#3280))
([10517f3](10517f3))
* Functions and procedures schemas and generated sources
([#3262](#3262))
([9b70f87](9b70f87))
* Functions sdk update
([#3254](#3254))
([fc1eace](fc1eace))
* Handle missing fields in function and procedure
([#3273](#3273))
([53e7a0a](53e7a0a))
* Procedures schemas and generated sources
([#3263](#3263))
([211ad46](211ad46))
* Procedures sdk update
([#3255](#3255))
([682606a](682606a))
* Rework account parameter resource
([#3264](#3264))
([15aa9c2](15aa9c2))
* Rework data types
([#3244](#3244))
([05ada91](05ada91))
* support table data type
([#3274](#3274))
([13401d5](13401d5))
* Tag association v1 readiness
([#3210](#3210))
([04f6d54](04f6d54))
* Test imports and small fixes
([#3276](#3276))
([a712195](a712195))
* Unsafe execute v1 readiness
([#3266](#3266))
([c4f1e8f](c4f1e8f))
* Use new data types in sql builder for functions and procedures
([#3247](#3247))
([69f677a](69f677a))


### 🔧 **Misc**

* Add ShowByID filtering generation
([#3227](#3227))
([548ec42](548ec42))
* Adress small task-related todos
([#3243](#3243))
([40de9ae](40de9ae))
* Apply masking
([#3234](#3234))
([c209a8a](c209a8a))
* fix missing references in toOpts and changes with newlines
([#3240](#3240))
([246547f](246547f))
* function tests
([#3279](#3279))
([5af6efb](5af6efb))
* Improve config builders
([#3207](#3207))
([425787c](425787c))
* Revert to proper env
([#3238](#3238))
([5d4ed3b](5d4ed3b))
* Use service user for ci
([#3228](#3228))
([2fb50d7](2fb50d7))


### 🐛 **Bug fixes:**

* Make blocked_roles_field optional in OAuth security integrations
([#3267](#3267))
([7197b57](7197b57))
* Minor fixes
([#3231](#3231))
([1863bf6](1863bf6))
* Minor fixes 2
([#3230](#3230))
([73b7e74](73b7e74))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants