Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Functions and procedures schemas and generated sources #3262

Merged
merged 15 commits into from
Dec 11, 2024
Merged

feat: Functions and procedures schemas and generated sources #3262

merged 15 commits into from
Dec 11, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Dec 10, 2024 •
edited
Loading

Add base for all new function resources:

  • define resource schema for each function type
  • add base definition for each function
  • add parameters logic (both for functions and procedures)
  • regenerate and manually adjust show output schemas (both for functions and procedures)
  • generate all resource assertions for each function resource
  • generate model builders for each function resource
  • generate docs for the new resources (without examples yet)

Next PRs:

  • the same with procedures
  • basic logic with tests for each resource
  • complex tests for different fields
  • migration guide/documentation improvements (examples and limitations)
  • data sources for functions and procedures

@github-actions GitHub Actions
Copy link

Integration tests cancelled for bfab298ecd613d66d904e53ab564b221df06ab73

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review December 10, 2024 13:06
sfc-gh-jcieslak
sfc-gh-jcieslak reviewed Dec 10, 2024
View reviewed changes
pkg/resources/function_commons.go Outdated Show resolved Hide resolved
pkg/sdk/common_types.go Show resolved Hide resolved
pkg/resources/function_commons.go Show resolved Hide resolved
pkg/resources/function_commons.go Outdated Show resolved Hide resolved
pkg/resources/function_commons.go Show resolved Hide resolved
pkg/resources/function_commons.go Show resolved Hide resolved
pkg/resources/function_commons.go Show resolved Hide resolved
pkg/resources/function_commons.go Show resolved Hide resolved
@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Dec 10, 2024
Merged
@github-actions GitHub Actions
Copy link

Integration tests failure for ded4b41992cf8e89db4b8eb43909d493f81d6764

Base automatically changed from procedures-sdk-update to main December 10, 2024 15:39
@sfc-gh-asawicki sfc-gh-asawicki force-pushed the functions-and-procedures-schemas-and-generated-sources branch from ded4b41 to bfa01db Compare December 10, 2024 16:00
@github-actions GitHub Actions
Copy link

Integration tests cancelled for bfa01dbbc6c81f7bdffb9f40f12e0d281fed2af9

sfc-gh-jmichalak
sfc-gh-jmichalak approved these changes Dec 10, 2024
View reviewed changes
pkg/resources/function_parameters.go Show resolved Hide resolved
pkg/resources/function_commons.go Show resolved Hide resolved
pkg/resources/function_commons.go Show resolved Hide resolved
pkg/resources/function_commons.go
Required: true,
ValidateDiagFunc: IsDataTypeValid,
DiffSuppressFunc: DiffSuppressDataTypes,
Description: "The argument type.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: add a link to Snowflake docs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a link in description for the wrapping "arguments".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the link to https://docs.snowflake.com/en/sql-reference/intro-summary-data-types.

pkg/resources/function_commons.go Show resolved Hide resolved
pkg/resources/function_commons.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Integration tests failure for 5b195d01f6d5612603bf7367c0964762059cf282

@sfc-gh-asawicki sfc-gh-asawicki merged commit 9b70f87 into main Dec 11, 2024
8 of 9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the functions-and-procedures-schemas-and-generated-sources branch December 11, 2024 07:52
@snowflake-release-please snowflake-release-please bot mentioned this pull request Dec 11, 2024
Merged
sfc-gh-asawicki added a commit that referenced this pull request Dec 11, 2024
@sfc-gh-asawicki
feat: Procedures schemas and generated sources (#3263)
211ad46 
Continuation to
#3262:
- define resource schema for each procedure type
- add base definition for each procedure
- generate all resource assertions for each procedure resource
- generate model builders for each procedure resource
- generate docs for the new resources (without examples yet)

Next PRs:
- basic logic with tests for each resource
- complex tests for different fields
- migration guide/documentation improvements (examples and limitations)
- data sources for functions and procedures
sfc-gh-jcieslak pushed a commit that referenced this pull request Dec 12, 2024
@snowflake-release-please
chore(main): release 0.100.0 (#3237)
5139b1a 
🤖 I have created a release *beep* *boop*
---


##
[0.100.0](v0.99.0...v0.100.0)
(2024-12-12)


### 🎉 **What's new:**

* Account v1 readiness
([#3236](#3236))
([5df33a8](5df33a8))
* Account v1 readiness generated files
([#3242](#3242))
([3df59dd](3df59dd))
* Account v1 readiness resource
([#3252](#3252))
([8f5698d](8f5698d))
* Add a new account roles data source
([#3257](#3257))
([b3d6b9e](b3d6b9e))
* Add account data source
([#3261](#3261))
([6087fc9](6087fc9))
* Add all other functions and procedures implementations
([#3275](#3275))
([7a6f68d](7a6f68d))
* Basic functions implementation
([#3269](#3269))
([6d4a103](6d4a103))
* Basic procedures implementation
([#3271](#3271))
([933335f](933335f))
* Docs, test, and missing parameter
([#3280](#3280))
([10517f3](10517f3))
* Functions and procedures schemas and generated sources
([#3262](#3262))
([9b70f87](9b70f87))
* Functions sdk update
([#3254](#3254))
([fc1eace](fc1eace))
* Handle missing fields in function and procedure
([#3273](#3273))
([53e7a0a](53e7a0a))
* Procedures schemas and generated sources
([#3263](#3263))
([211ad46](211ad46))
* Procedures sdk update
([#3255](#3255))
([682606a](682606a))
* Rework account parameter resource
([#3264](#3264))
([15aa9c2](15aa9c2))
* Rework data types
([#3244](#3244))
([05ada91](05ada91))
* support table data type
([#3274](#3274))
([13401d5](13401d5))
* Tag association v1 readiness
([#3210](#3210))
([04f6d54](04f6d54))
* Test imports and small fixes
([#3276](#3276))
([a712195](a712195))
* Unsafe execute v1 readiness
([#3266](#3266))
([c4f1e8f](c4f1e8f))
* Use new data types in sql builder for functions and procedures
([#3247](#3247))
([69f677a](69f677a))


### 🔧 **Misc**

* Add ShowByID filtering generation
([#3227](#3227))
([548ec42](548ec42))
* Adress small task-related todos
([#3243](#3243))
([40de9ae](40de9ae))
* Apply masking
([#3234](#3234))
([c209a8a](c209a8a))
* fix missing references in toOpts and changes with newlines
([#3240](#3240))
([246547f](246547f))
* function tests
([#3279](#3279))
([5af6efb](5af6efb))
* Improve config builders
([#3207](#3207))
([425787c](425787c))
* Revert to proper env
([#3238](#3238))
([5d4ed3b](5d4ed3b))
* Use service user for ci
([#3228](#3228))
([2fb50d7](2fb50d7))


### 🐛 **Bug fixes:**

* Make blocked_roles_field optional in OAuth security integrations
([#3267](#3267))
([7197b57](7197b57))
* Minor fixes
([#3231](#3231))
([1863bf6](1863bf6))
* Minor fixes 2
([#3230](#3230))
([73b7e74](73b7e74))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-jmichalak sfc-gh-jmichalak sfc-gh-jmichalak approved these changes

@sfc-gh-jcieslak sfc-gh-jcieslak sfc-gh-jcieslak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-asawicki @sfc-gh-jcieslak @sfc-gh-jmichalak