-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply new registration mechanism #141
Apply new registration mechanism #141
Conversation
Please test it on your side before merging: while testing it on my side using the examples, I've had a lots of warning because of multiple registration in the factory. This might be due to multiple loading of the library. Problem is that the example are using some custom headers and so on, I preferred to have your feedback before taking a closer look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it stands, I think the code is good. But, you're right, I'll try to compile it on my machine and test scenes before a possible merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, @adagolodjo could you take the opportunity to review all the Component descriptions? I see a lot of copy/paste.
@alxbilger, This has been done in some pending PRs, and some of them are deprecated. So I'm trying to reactivate them as I go. Let's push this one before it becomes deprecated as well. |
@adagolodjo ok but remove the comments looking like:
It's very related to this PR. |
Done, here bakpaul#1. |
373aa69
to
89c9053
Compare
89c9053
to
84806f9
Compare
@bakpaul @adagolodjo I took the liberty to:
I recommend a last review from you. @adagolodjo I realized seconds ago that you did some of the changes in a dedicated PR. Sorry |
I'll take a look. In the mean(time, do I still need to merge bakpaul#1 ? |
@bakpaul no it can be closed. I did not see this PR unfortunately. |
This applies the new factory registration mechanism as introduced by [All] ObjectFactory: Explicit components registration #4429
In the process I've encountered a problem of consistency of namespace. I needed all of the registering methods to be in the
Cosserat
namespace. But a lot of SOFA namespace are used. This is bad practice, only the Cosserat namespace should be used in this plugin.