Fix/crashing when generating walls #6289
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a nullptr check. It fixes #6279.
When slicing the file in #6279, there is a ACCESS_VIOLATION exception thrown by
annotate_vertex(edge.vertex0(), edge.is_secondary() ? VertexCategory::OnContour : VertexCategory::Outside)
;.edge.vertex0()
appears to be null in some cases. The root cause is still unknown, but adding a nullptr check to skip this lineedge.vertex0()
seems to be working.Screenshots/Recordings/Graphs
Tests
OrcaSlicer can now slice the 3mf file user provided in the bug report.
Side.Entry.Housing.1.zip
I found these two lines in the debug log: