Fix/crashing when generating walls #6325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from prusa3d/PrusaSlicer@8784ca0 Co-authored-by: Lukáš Hejl <hejl.lukas@gmail.com>
… detection of invalid Voronoi diagrams. This happens because we didn't set a modified flag that is required to be set before we use the new Voronoi graph. Possibly related to #12385 Cherry-picked from prusa3d/PrusaSlicer@2de1f3a Co-authored-by: Lukáš Hejl <hejl.lukas@gmail.com>
|
Nice one. Thank you @Noisyfox and @Azio-Pantheon for digging into this issue. |
SoftFever
approved these changes
Aug 3, 2024
SoftFever
approved these changes
Aug 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces PR #6289 by cherry-picking a few fixes from Prusa.
Thanks for the work by @Azio-Pantheon and Prusa
This should fix #6279