Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Enable Framework" checkbox option #65

Closed
L-McKendrick opened this issue Sep 28, 2022 · 4 comments
Closed

Add "Enable Framework" checkbox option #65

L-McKendrick opened this issue Sep 28, 2022 · 4 comments
Labels
enhancement New feature or request to-do Something that needs to be completed.
Milestone

Comments

@L-McKendrick
Copy link
Contributor

Concept:

Basically a checkbox at the top of the "SIA Framework Settings" that says "Enable Framework". Unchecked by default, when this box is not ticked, then none of the framework runs.

This allows those who have the mod loaded but aren't making an SIA mission to have this mod loaded without having to frustratingly deal with the scripts when messing around in the editor.

If too much work for the Alpha release, this should definitely be done by the public release.

@L-McKendrick L-McKendrick added enhancement New feature or request to-do Something that needs to be completed. labels Sep 28, 2022
@L-McKendrick L-McKendrick modified the milestone: Alpha Release Sep 28, 2022
@SiegeToaster
Copy link
Member

SiegeToaster commented Sep 28, 2022 via email

@L-McKendrick
Copy link
Contributor Author

L-McKendrick commented Sep 28, 2022

Could also potentially replace the "initialize framework" tab. Nah that's silly

@SiegeToaster
Copy link
Member

Making the initialize framework button a checkbox would make things pretty complicated and would require a new extension to delete description.ext. Extension would be fairly complicated due to having to check the file contents to ensure that nothing the user wrote is being overwritten, which could cause memory/CPU usage problems if the file is incredibly large.

All in all, putting in functionality to enable and disable the framework at whim would be quite involved, to start off we'd have to do a complete audit of all of the variables that are set to the mission.sqm file so that they could all be removed. Then, if someone accidentally disables the framework they lose all of their stuff. imo the button can serve the same purpose (allowing a GM to make a mission without the mod interfering) while being much easier to implement, I also see no reason why you'd enable and then disable the famework.

@L-McKendrick L-McKendrick added this to the Beta Release milestone Sep 29, 2022
@SiegeToaster
Copy link
Member

Should be able to use the GET_CONFIG macro to check the frameworkInit hidden value. Need to check if that can also be used in 3DEN (configuration module).

SiegeToaster added a commit that referenced this issue Nov 24, 2022
* replace real_date extension with CBA_fnc_weekDay
resolves #70

* create script to automatically update #12

* copy commonObject actions to function
function not yet used

* disable functionality if framework not initialized
resolves #65

* add vehicle info functions; see #40
from https://github.com/Soliders-in-Arms-Arma-3-Group/SIA-Mission-Framework.VR/blob/main/sia_f/functions/briefing/fn_vehicleInfo.sqf

* touch up parameters; misc.

* move obj attributes to file; supportInfo option
#40 front end

* fix actions stuff (I think)

* finish vehicle info briefing stuff
Still needs some final touches, but pretty much done.

* add zeus actions to func; misc.

* save loadout on mission start
requested by Austin [here](https://discord.com/channels/689674061366034435/690255520728350720/1029724157413445632)

* move proper actions to buttonActions/playerActions
misc

* move core serverPostInit into functions
resolves #71

* add new functions to prep

* bug fixes; convert spaces to tabs

* update vehicle info header; formatting

* fix #import instead of #include; delete build.bat
hopefully build.bat isn't used, but it just runs hemtt

* add expression disclaimer in configuration readme
not that anyone will ever read it.

* progress on #74, formatting/syntax, documentation

* Fix for #74

* safeStart Safety and Init readded
Resolves: #76

* minor tweaks
- Removed error message when a section of the briefing is empty.
- Added zeusActions function to run on postClientInit.

* XEH_PREP alphabetized

* addActions non-ace tweaks

* fix formatting

* make.py now works with pre-defined keys

* update version to v1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request to-do Something that needs to be completed.
Projects
None yet
Development

No branches or pull requests

2 participants