SLVS-1592 Update TaintStore with taints from SLCore #5821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
force-pushed
the
gb/taint-synchronizer
branch
2 times, most recently
from
0a003b8
to
ccd15a9
Compare
Base automatically changed from
gb/taint-dto-conversion
to
feature/severity-modes
November 12, 2024 09:00
georgii-borovinskikh-sonarsource
force-pushed
the
gb/taint-synchronizer
branch
from
6b76dd4
to
58fb237
Compare
georgii-borovinskikh-sonarsource
force-pushed
the
gb/taint-synchronizer
branch
from
58fb237
to
0bce40b
Compare
georgii-borovinskikh-sonarsource
changed the title
georgii-borovinskikh-sonarsource
marked this pull request as ready for review
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
gabriela-trutan-sonarsource
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Functionality works, but:
- You missed a todo that was supposed to be done in this task in TaintVulnerabilityListener
- I have some more feedback
src/IssueViz.Security.UnitTests/Taint/TaintIssuesConfigurationScopeMonitorTests.cs
Outdated
Show resolved
Hide resolved
src/IssueViz.Security/Taint/TaintList/ViewModels/TaintIssuesControlViewModel.cs
Show resolved
Hide resolved
…taint-synchronizer # Conflicts: # src/IssueViz.Security/Taint/TaintSyncPackage.cs
|
georgii-borovinskikh-sonarsource
requested a review
from gabriela-trutan-sonarsource
gabriela-trutan-sonarsource
approved these changes
Nov 14, 2024
georgii-borovinskikh-sonarsource
merged commit 66a7607
into
feature/severity-modes
4 checks passed
vnaskos-sonar
pushed a commit
that referenced
this pull request
Nov 18, 2024
georgii-borovinskikh-sonarsource
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of