Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLVS-1592 Update TaintStore with taints from SLCore #5821

Merged
Merged
6 changes: 3 additions & 3 deletions src/Core/ThreadHandlingExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ public static Task RunOnBackgroundThread(this IThreadHandling threadHandling, Ac
syncMethod();
return Task.CompletedTask;
});
public static Task RunOnBackgroundThread(this IThreadHandling threadHandling, Func<Task> asyncMethod) => Task.FromResult(threadHandling.RunOnBackgroundThread(async () =>

public static Task RunOnBackgroundThread(this IThreadHandling threadHandling, Func<Task> asyncMethod) => threadHandling.RunOnBackgroundThread(async () =>
{
await asyncMethod();
return 0;
}));
});
}

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/*
* SonarLint for Visual Studio
* Copyright (C) 2016-2024 SonarSource SA
* mailto:info AT sonarsource DOT com
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 3 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/

using SonarLint.VisualStudio.IssueVisualization.Security.Taint;
using SonarLint.VisualStudio.SLCore.State;

namespace SonarLint.VisualStudio.IssueVisualization.Security.UnitTests.Taint;

[TestClass]
public class TaintIssuesConfigurationScopeMonitorTests
{
[TestMethod]
public void Ctor_SubscribesToConfigurationScopeEvents()
{
var activeConfigScopeTracker = Substitute.For<IActiveConfigScopeTracker>();

_ = new TaintIssuesConfigurationScopeMonitor(activeConfigScopeTracker, Substitute.For<ITaintIssuesSynchronizer>());

activeConfigScopeTracker.Received().CurrentConfigurationScopeChanged += Arg.Any<EventHandler>();
}

[TestMethod]
public void Dispose_UnsubscribesToConfigurationScopeEvents()
{
var activeConfigScopeTracker = Substitute.For<IActiveConfigScopeTracker>();
var testSubject = new TaintIssuesConfigurationScopeMonitor(activeConfigScopeTracker, Substitute.For<ITaintIssuesSynchronizer>());
georgii-borovinskikh-sonarsource marked this conversation as resolved.
Show resolved Hide resolved

testSubject.Dispose();

activeConfigScopeTracker.Received().CurrentConfigurationScopeChanged -= Arg.Any<EventHandler>();
}

[TestMethod]
public void ConfigScopeChangedEvent_CallsTaintSynchronizer()
{
var activeConfigScopeTracker = Substitute.For<IActiveConfigScopeTracker>();
var configurationScope = new ConfigurationScope("config scope");
activeConfigScopeTracker.Current.Returns(configurationScope);
var taintIssuesSynchronizer = Substitute.For<ITaintIssuesSynchronizer>();
_ = new TaintIssuesConfigurationScopeMonitor(activeConfigScopeTracker, taintIssuesSynchronizer);

activeConfigScopeTracker.CurrentConfigurationScopeChanged += Raise.Event<EventHandler>();

taintIssuesSynchronizer.Received(1).UpdateTaintVulnerabilitiesAsync(configurationScope);
}
}
Loading