This repository has been archived by the owner on Aug 10, 2023. It is now read-only.
Support aliases #31
Merged
Support aliases #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's fine, no problem 👍 |
|
🙏 |
|
We now work around accents. This helps for the following cards
|
zhouzi
approved these changes
Aug 6, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used and adapted https://github.com/PabloSzx/Gwent-Cards/blob/master/src/data/nicknames.json
@PabloSzx is it all right?
My modification includes:
There are still issues with accentuated letters. We should support them. Note also that they are normalized in the aliases map. So some aliases like Schirrú are not working yet.