Fix missing var keyword
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would crash when used in Chrome for example.
Soreine
added a commit
to Soreine/hyper-gwent
that referenced
this pull request
Aug 5, 2017
|
Well technically I think it fails whenever we use JS |
zhouzi
pushed a commit
to Soreine/hyper-gwent
that referenced
this pull request
Aug 6, 2017
* Added aliases * Add failing test for accentuated letters * Add back accents * Support accents * Fix error in Chrome See tyxla/remove-accents#11
zhouzi
pushed a commit
to Soreine/hyper-gwent
that referenced
this pull request
Aug 7, 2017
* Add Competitive_Gwent * Refactor tooltip code * Following mouse * Keep card within viewport * Added aliases * Add failing test for accentuated letters * Add back accents * Support accents * Fix error in Chrome See tyxla/remove-accents#11 * Support GwentDB (don't double tooltips) * Cleanup * Wrote content for home page * Wrote content for home page * Add frog and fix ADC * Hyper Gwent logo using Sketch * Improve R * Fix kerning * Add colors 🌈 * Improving homepage style * Add dandelion and geralt avatars * Fix walker to skip script and styles tags * Added emotes :p * Fix responsiveness * Another wordplay * Dark theme * Grammar * Add link to issues * Style issues * Add gradient background * Link to compose a message * Add favicon * Remove border from logo * Add back border, but better * Adjust button colors * Add warning for non Chrome users. Fix rem * Fix rem * Remove list style * Update manifest.json * Limit extension to GwentDB decks * Fix manifest.json * Extend to GwentDB forums
|
Thanks for that one! |
|
@Soreine If you want to use this one in your projects immediately, you can bump your dep version to |
|
That's very nice from you. Thanks !
|
|
I really appreciate your contribution 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing
varkeyword would crash when in Chrome, with an error "accented" is not defined