Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model - Uniquify sources #373

Closed
2 tasks
mjy opened this issue Apr 4, 2018 · 4 comments
Closed
2 tasks

Model - Uniquify sources #373

mjy opened this issue Apr 4, 2018 · 4 comments
Assignees
@mjy @TuckerJD @jlpereira
Labels
model Issue pertains to an app/model.

Comments

@mjy
Copy link
Member

mjy commented Apr 4, 2018

Create Source methods and specs that produce reasonable results for

  • #similar
  • #identical

May need to subclass specific methods for Verbatim vs. BibTeX.

Should follow similar pattern to #288, but potentially much more complicated given the many more attributes.
@mjy mjy added the model Issue pertains to an app/model. label Apr 4, 2018
@TuckerJD
Copy link
Contributor

TuckerJD commented Apr 9, 2018

Is this to return a scope of similar/identical, or as methods returning Booleans for comparing two specific sources?

@mjy
Copy link
Member Author

mjy commented Apr 9, 2018 via email

TuckerJD added a commit that referenced this issue Apr 9, 2018
@TuckerJD
#373 Uniquify sources: Add stub methods #similar and #identical.
2775508
@mjy
Copy link
Member Author

mjy commented Apr 12, 2018

Pertinent fast finding with postgres

You can just pass in model.attributes.keys - HOUSEKEEPING_ATTRIBUTES - MODEL_ATTRIBUTES to the latter.

TuckerJD added a commit that referenced this issue May 4, 2018
@TuckerJD
#373 Uniquify sources: Adding IGNORE_CONSTANTS, modifying sub-classes,
759c41f 
 Adding RSpecs.
TuckerJD added a commit that referenced this issue May 8, 2018
@TuckerJD
#373 Uniquify sources: Adding RSpecs.
5217f5d
TuckerJD added a commit that referenced this issue May 8, 2018
@TuckerJD
#373 Uniquify sources: Adding RSpecs.
93e2b64
TuckerJD added a commit that referenced this issue May 9, 2018
@TuckerJD
#373 Uniquify sources: Adding Stripper#tested_attributes().
481ebde
TuckerJD added a commit that referenced this issue May 9, 2018
@TuckerJD
#373 Uniquify sources: Differentiation of IGNORE constants on a
b8f44a8 
 per-subclass basis.
TuckerJD added a commit that referenced this issue May 10, 2018
@TuckerJD
#373 Uniquify sources: Adding RSpecs for Source::Bibtex.
2f445a7
TuckerJD added a commit that referenced this issue May 10, 2018
@TuckerJD
#373 Uniquify sources: Removing IGNORE_CONSTANTS from Source.
06384db
TuckerJD added a commit that referenced this issue May 10, 2018
@TuckerJD
#373 Uniquify sources: Source::Human#identical, #similar,
1f109e6 
 ::identical(attr), and ::similar(attr) override IsData version.
@TuckerJD TuckerJD mentioned this issue May 10, 2018
Merged
TuckerJD added a commit that referenced this issue May 10, 2018
@TuckerJD
#373 Uniquify sources: Fixing build SQL error.
21fc7a5
@mjy mjy assigned mjy and jlpereira Oct 28, 2020
@mjy
Copy link
Member Author

mjy commented Sep 17, 2024

Closing and cross-referencing #970.

@mjy mjy closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjy mjy

@TuckerJD TuckerJD

@jlpereira jlpereira

Labels
model Issue pertains to an app/model.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mjy @TuckerJD @jlpereira