Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify objects / aka uniquify [was: A task is needed to merge two TaxonNames] #970

Open
proceps opened this issue May 7, 2019 · 12 comments
Labels
task The issue requests a new TaxonWorks "TASKS" card.

Comments

@proceps
Copy link
Contributor

proceps commented May 7, 2019

Expected behavior. Before merging, all attributes from one name are transferred from one name to another. Duplicated attributes get destroyed. Self attributes (Author, parent, rank, etc.) stay unchanged. After that, one TaxonName get destroyed.

@proceps proceps added the task The issue requests a new TaxonWorks "TASKS" card. label May 7, 2019
@debpaul
Copy link
Contributor

debpaul commented Dec 1, 2021

This issue discussed today in the Nomenclature office hours. It's a larger issue too in that some steps to merge can be automated, other steps will have to manual, and it is not just for duplicate taxon names, but other duplicates (OTUs, family-group names, etc).

DD: suggest to put sources with nominotypical names to make this easier to merge in future (from DP, did I say this correctly @proceps?)

@mjy
Copy link
Member

mjy commented Dec 1, 2021

I think, if our model (and corresponding UI/UX) is setup correctly, we should only have to merge names if there are truly duplicates because of human error. Otherwise this voids the principle of "no changes, only new data".

@mabecabrera
Copy link

mabecabrera commented Jul 5, 2022

So needed for data curation purposes, including migration errors.

@mjy mjy changed the title A task is needed to merge two TaxonNames Unify objects [was: A task is needed to merge two TaxonNames] Jul 8, 2024
@mjy
Copy link
Member

mjy commented Jul 8, 2024

Endpoint:

/unify?remove_global_id=<global_id>&keep_global_id=<keep_global_id>&preview=true

@mjy mjy changed the title Unify objects [was: A task is needed to merge two TaxonNames] Unify objects / aka uniquify [was: A task is needed to merge two TaxonNames] Jul 8, 2024
@mjy
Copy link
Member

mjy commented Jul 9, 2024

To get a preview count of the numer of existing records use /unify/metadata?global_id=gid://taxon-works/Otu/1

jlpereira added a commit that referenced this issue Jul 12, 2024
@mjy
Copy link
Member

mjy commented Jul 14, 2024

  • DataAttribute and Combination can be removed
  • Radial navigator beside selected object(s)
  • Radial annotator beside selected object(s)
  • Object radial beside selected objects(s)
  • Add radial navigator slice "Uniquify" that points an object to this task, and pre-initializes the left side
  • Add headers and style(?) to left ('Keep') and right ('Remove') columns
  • Maybe drop in Smart selector if it exists for the class, on choice of Model?

@mjy
Copy link
Member

mjy commented Jul 16, 2024

  • Use name attribute in preview metadata for related row label
  • Collapse smart selector, if present, and use undo button to clear OTU and make it re-appear
  • Prevent identical object from being selected on both sides
  • When tasked entered from URL and object(s) changed, update URL

@hhopkins77
Copy link

@mjy per your request: Here is just one example of something that comes up often: repositories that need unifying.

one ZMB + ZMHUB + BHU need to be unified

and

a second ZMB + ZMBH need to be unified

@hhopkins77
Copy link

@mjy I'm wondering if the author uniquify task could be subsumed into the new unify one? I think the new one might be easier.

@proceps
Copy link
Contributor Author

proceps commented Jul 25, 2024

I use people uniquify very often. And in most cases it is many to one. I do not think it is reasonable to replace it.

@hhopkins77
Copy link

@mjy I don't have an example just now but the ability to unify sources is needed.

@hhopkins77
Copy link

@mjy I need to be able to unify Taxon Name IDs. For example, I need everything associated with 1043436 (a ghost) to be unified with 1003420 (the "real" taxon name id). This example is in Plecoptera SF and this phenomenon appears to be a byproduct of migration. I don't know how many of these there are, (I'm guessing quite a few), and they can take forever to correct depending on the quantity of data attached to the ghost so a unifiy task for this would be a great timesaver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task The issue requests a new TaxonWorks "TASKS" card.
Projects
None yet
Development

No branches or pull requests

5 participants