Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pair on Optional #1296

Merged
merged 15 commits into from
Sep 2, 2020
Merged

Pair on Optional #1296

merged 15 commits into from
Sep 2, 2020

Conversation

alexander-yevsyukov
Copy link
Contributor

@alexander-yevsyukov alexander-yevsyukov commented Sep 1, 2020

This PR adds a factory method to create Pair using Optional as the second parameter (see #1228).

Other minor changes:

  • Fixed style of package description headers. Previously they were H1, as demanded by IDEA style check for Javadoc.
    It turned out that this...
    1) was incorrect from the HTML point of view which assumes only one H1 header per page;
    2) did not meet header nesting in the generated HTML which has package description section as H2.
  • Improved code of precondition checks. Each Tuple class now has a companion-like section of code which avoids
    repeating passing the same class name for static precondition checks exposed by the Tuple class.

@alexander-yevsyukov alexander-yevsyukov self-assigned this Sep 1, 2020
@alexander-yevsyukov alexander-yevsyukov marked this pull request as draft September 1, 2020 20:57
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #1296 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1296      +/-   ##
============================================
+ Coverage     91.03%   91.07%   +0.04%     
- Complexity     4731     4748      +17     
============================================
  Files           608      608              
  Lines         15063    15088      +25     
  Branches        854      854              
============================================
+ Hits          13712    13741      +29     
+ Misses         1082     1080       -2     
+ Partials        269      267       -2     

@alexander-yevsyukov alexander-yevsyukov marked this pull request as ready for review September 1, 2020 21:35
Copy link
Contributor

@dmdashenkov dmdashenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-yevsyukov, LGTM with a single suggestion (to 4 files).

server/src/main/java/io/spine/server/tuple/Pair.java Outdated Show resolved Hide resolved
server/src/main/java/io/spine/server/tuple/Quartet.java Outdated Show resolved Hide resolved
server/src/main/java/io/spine/server/tuple/Quintet.java Outdated Show resolved Hide resolved
server/src/main/java/io/spine/server/tuple/Triplet.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants