-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pair on Optional
#1296
Merged
Merged
Pair on Optional
#1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
============================================
+ Coverage 91.03% 91.07% +0.04%
- Complexity 4731 4748 +17
============================================
Files 608 608
Lines 15063 15088 +25
Branches 854 854
============================================
+ Hits 13712 13741 +29
+ Misses 1082 1080 -2
+ Partials 269 267 -2 |
dmdashenkov
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-yevsyukov, LGTM with a single suggestion (to 4 files).
This was referenced Sep 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a factory method to create
Pair
usingOptional
as the second parameter (see #1228).Other minor changes:
It turned out that this...
1) was incorrect from the HTML point of view which assumes only one H1 header per page;
2) did not meet header nesting in the generated HTML which has package description section as H2.
Tuple
class now has a companion-like section of code which avoidsrepeating passing the same class name for static precondition checks exposed by the
Tuple
class.