Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Perform clear-and-replace when applying entity Migration #1405

Merged
merged 5 commits into from
Oct 25, 2021

Conversation

armiol
Copy link
Contributor

@armiol armiol commented Oct 24, 2021

This changeset addresses #1403, but just for 1.x branch.

The library version is set to 1.7.7-SNAPSHOT.3.

@armiol armiol self-assigned this Oct 24, 2021
@armiol armiol requested a review from dmitrykuzmin October 24, 2021 13:41
@armiol
Copy link
Contributor Author

armiol commented Oct 24, 2021

@dmitrykuzmin PTAL.

@armiol armiol changed the title Perform clear-and-replace when applying entity Migration [1.x] Perform clear-and-replace when applying entity Migration Oct 24, 2021
@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #1405 (c2d6686) into 1.x-dev (3893bf1) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             1.x-dev    #1405      +/-   ##
=============================================
- Coverage      91.08%   91.05%   -0.04%     
+ Complexity      4793     4791       -2     
=============================================
  Files            614      614              
  Lines          15201    15203       +2     
  Branches         860      860              
=============================================
- Hits           13846    13843       -3     
- Misses          1090     1091       +1     
- Partials         265      269       +4     

Copy link
Contributor

@dmitrykuzmin dmitrykuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of minor comments.

/**
* Fills the state of the migrated {@code ProcessManager} with some random values.
*/
public class RandomFillProcess
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public class RandomFillProcess
public final class RandomFillProcess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants