[2.x] Perform clear-and-replace when applying entity Migration
#1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1419 +/- ##
=========================================
Coverage 91.12% 91.12%
Complexity 4930 4930
=========================================
Files 628 628
Lines 15420 15421 +1
Branches 893 893
=========================================
+ Hits 14051 14053 +2
Misses 1066 1066
+ Partials 303 302 -1 |
dmdashenkov
approved these changes
Nov 16, 2021
| .setId(newUuid().hashCode()) | ||
| .build(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please kill this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset addresses #1403, now for 2.x
masterbranch. In short, previously during the entity migration the old state was being merged with the new state returned by theMigrationinstance. That led to a number of unwanted side effects and bugs.Now, the entity
Migrationroutines fully replace the old state with the new state, as per its original API design.(a similar PR has been merged into 1.x branch)
The library version has been set to
2.0.0-SNAPSHOT.78.