Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Import events from 3rd-party with respect for tenancy #1503

Merged
merged 4 commits into from
Feb 7, 2023

Conversation

armiol
Copy link
Contributor

@armiol armiol commented Feb 7, 2023

When it comes about importing the third-party events, the framework provides a ThirdPartyContext tool.

However, in a multi-tenant application, the imported events were dispatched in a straightforward manner, without specifying the TenantId via TenantAwareRunner.

The corresponding test was also flawed: in fact, it was dispatching the events to a single-tenant Bounded Context.

This PR addresses the issue by fixing the test and making IntegrationBroker (an intermediary between ThirdPartyContext and "domestic" Bounded Contexts) to explicitly use TenantAwareOperation during the event dispatch.

@armiol armiol self-assigned this Feb 7, 2023
@armiol armiol changed the base branch from master to 1.x-dev February 7, 2023 10:24
@armiol armiol marked this pull request as ready for review February 7, 2023 12:46
@armiol
Copy link
Contributor Author

armiol commented Feb 7, 2023

@yevhenii-nadtochii PTAL.

Copy link
Contributor

@yevhenii-nadtochii yevhenii-nadtochii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@armiol armiol merged commit c506f3b into 1.x-dev Feb 7, 2023
@armiol armiol deleted the 1.x-tenant-aware-integration-broker branch February 7, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants