Import events from 3rd-party with respect for tenancy #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1516 +/- ##
=========================================
Coverage 89.71% 89.71%
- Complexity 4933 4934 +1
=========================================
Files 635 635
Lines 15453 15454 +1
Branches 888 888
=========================================
+ Hits 13863 13864 +1
Misses 1286 1286
Partials 304 304 |
|
@alexander-yevsyukov PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset is a port of #1503 to
master. Here is a full PR description for reviewer's convenience.When it comes about importing the third-party events, the framework provides a
ThirdPartyContexttool.However, in a multi-tenant application, the imported events were dispatched in a straightforward manner, without specifying the
TenantIdviaTenantAwareRunner.The corresponding test was also flawed: in fact, it was dispatching the events to a single-tenant Bounded Context.
This PR addresses the issue by fixing the test and making
IncomingEventObserver(part ofIntegrationBroker, an intermediary betweenThirdPartyContextand "domestic" Bounded Contexts) to explicitly useTenantAwareOperationduring the event dispatch.The version is set to
2.0.0-SNAPSHOT.146.