Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest from open 2020 03 11 #79

Closed
wants to merge 373 commits into from
Closed

Latest from open 2020 03 11 #79

wants to merge 373 commits into from

Conversation

joshea0
Copy link

@joshea0 joshea0 commented Mar 11, 2020

Release Notes

This is a huge merge because we have not been keeping a regular update from nucore-open. I am going to test it thoroughly in our staging environment before deploying to production.

Going forward, we will be merging nucore-open on a regular schedule to avoid merges this large in the future.

What is included

dependabot-preview bot and others added 30 commits July 22, 2019 11:23
@dependabot-preview @vandrijevik
Bump rake from 12.3.2 to 12.3.3 (wyeworks#2026)
ab2a835 
Bumps [rake](https://github.com/ruby/rake) from 12.3.2 to 12.3.3.
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](ruby/rake@v12.3.2...v12.3.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
Bump capybara from 3.25.0 to 3.26.0 (wyeworks#2027)
583d0ad 
Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.25.0 to 3.26.0.
- [Release notes](https://github.com/teamcapybara/capybara/releases)
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md)
- [Commits](teamcapybara/capybara@3.25.0...3.26.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
Bump eye-patch from 0.5.1 to 1.1.0 (wyeworks#2028)
b75e6f1 
Bumps [eye-patch](https://github.com/tablexi/eye-patch) from 0.5.1 to 1.1.0.
- [Release notes](https://github.com/tablexi/eye-patch/releases)
- [Commits](tablexi/eye-patch@v0.5.1...v1.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
Bump capybara from 3.26.0 to 3.27.0 (wyeworks#2032)
1285d88 
Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.26.0 to 3.27.0.
- [Release notes](https://github.com/teamcapybara/capybara/releases)
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md)
- [Commits](teamcapybara/capybara@3.26.0...3.27.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
Bump oj from 3.7.12 to 3.8.1 (wyeworks#2031)
6ca695d 
Bumps [oj](https://github.com/ohler55/oj) from 3.7.12 to 3.8.1.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](ohler55/oj@v3.7.12...v3.8.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
Bump capybara from 3.27.0 to 3.28.0 (wyeworks#2035)
93bd8de 
Bumps [capybara](https://github.com/teamcapybara/capybara) from 3.27.0 to 3.28.0.
- [Release notes](https://github.com/teamcapybara/capybara/releases)
- [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md)
- [Commits](teamcapybara/capybara@3.27.0...3.28.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
Bump shoulda-matchers from 4.1.1 to 4.1.2 (wyeworks#2034)
175bc12 
Bumps [shoulda-matchers](https://github.com/thoughtbot/shoulda-matchers) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/thoughtbot/shoulda-matchers/releases)
- [Changelog](https://github.com/thoughtbot/shoulda-matchers/blob/master/NEWS.md)
- [Commits](thoughtbot/shoulda-matchers@v4.1.1...v4.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
Bump paper_trail from 10.3.0 to 10.3.1 (wyeworks#2033)
5be3065 
Bumps [paper_trail](https://github.com/airblade/paper_trail) from 10.3.0 to 10.3.1.
- [Release notes](https://github.com/airblade/paper_trail/releases)
- [Changelog](https://github.com/paper-trail-gem/paper_trail/blob/master/CHANGELOG.md)
- [Commits](paper-trail-gem/paper_trail@v10.3.0...v10.3.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@vandrijevik
[#146050] Remove unused code for observing order detail status changes (
ba2218d 
wyeworks#2036)

* Remove unused code and settings for notifying on an order detail’s status changes

The default settings are commented out in both the nucore-nu and nucore-dartmouth repositories, so this code is not used anywhere.

* Remove unused email Notifier#order_detail_status_change
@vandrijevik
Reformat and alphabetize Capistrano deployment config (wyeworks#2037)
e0f69c5
@dependabot-preview @vandrijevik
Bump haml from 5.1.1 to 5.1.2 (wyeworks#2039)
091f9c5 
Bumps [haml](https://github.com/haml/haml) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/haml/haml/releases)
- [Changelog](https://github.com/haml/haml/blob/master/CHANGELOG.md)
- [Commits](haml/haml@v5.1.1...v5.1.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
[Security] Bump nokogiri from 1.10.3 to 1.10.4 (wyeworks#2038)
cc4accf 
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.3 to 1.10.4. **This update includes a security fix.**
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.10.3...v1.10.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
Bump haml_lint from 0.32.0 to 0.33.0 (wyeworks#2041)
f697b7c 
Bumps [haml_lint](https://github.com/sds/haml-lint) from 0.32.0 to 0.33.0.
- [Release notes](https://github.com/sds/haml-lint/releases)
- [Changelog](https://github.com/sds/haml-lint/blob/master/CHANGELOG.md)
- [Commits](sds/haml-lint@v0.32.0...v0.33.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
Bump oj from 3.8.1 to 3.9.0 (wyeworks#2043)
c7dc605 
Bumps [oj](https://github.com/ohler55/oj) from 3.8.1 to 3.9.0.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](ohler55/oj@v3.8.1...v3.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
Bump exception_notification from 4.3.0 to 4.4.0 (wyeworks#2042)
4c23623 
Bumps [exception_notification](https://github.com/smartinez87/exception_notification) from 4.3.0 to 4.4.0.
- [Release notes](https://github.com/smartinez87/exception_notification/releases)
- [Changelog](https://github.com/smartinez87/exception_notification/blob/master/CHANGELOG.rdoc)
- [Commits](smartinez87/exception_notification@v4.3.0...v4.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @vandrijevik
Bump sass-rails from 5.0.7 to 6.0.0 (wyeworks#2040)
da27e15 
Bumps [sass-rails](https://github.com/rails/sass-rails) from 5.0.7 to 6.0.0.
- [Release notes](https://github.com/rails/sass-rails/releases)
- [Commits](rails/sass-rails@v5.0.7...v6.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@vandrijevik
[#146050] Allow emailing purchasers on order status changes (wyeworks…
7fc2d88 
…#2044)

* Add flag for emailing purchasers on order status changes

* Surface Product#email_purchasers_on_order_status_changes in the UI

* Consolidate calls to delegate at top of OrderDetail class

* Remove commented-out spec code

* Remove unused OrderStatus#downcase_name

* Email the purchaser of an order when its status changes and the product is configured to do so
@vandrijevik
[#150534] Fix reference to LogEventSearcher, it is not in LogEvent (w…
23433e7 
…yeworks#2045)
@vandrijevik
[#146050] Send order status emails from OrderDetailBatchUpdater also (w…
74596a8 
…yeworks#2046)
@vandrijevik
[#146050] Update subject and body of email for order status change (w…
bd37523 
…yeworks#2047)
@vandrijevik
[#146050] Fix typo in text version of email (wyeworks#2048)
c29a661
@meara @rolfrussell
[#143406] facility senior staff can see problem queues (wyeworks#2055)
d1eb4d2 
* facility senior staff can see problem queues

* fix specs
@meara @rolfrussell
[#140481] remove footer from bulk email (wyeworks#2056)
9120e47 
* remove footer from bulk email

* fix specs
@meara @rolfrussell
handle start/end export for occupancies in account transaction export (…
2438e2f 
…wyeworks#2059)
@meara @rolfrussell
[#141584] move transactions in review into nav (wyeworks#2058)
d0add19 
* move transactions in review into nav

* fix spec
@jhanggi @rolfrussell
Fix spec broken by passing the fiscal year boundry (wyeworks#2066)
e8f55cc 
We're now in fiscal year 2020, so a test was failing because it was hard coded
to mean 2020 was in the future.
@dependabot-preview @jhanggi
Bump bullet from 6.0.1 to 6.0.2 (wyeworks#2049)
f64b052 
Bumps [bullet](https://github.com/flyerhzm/bullet) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/flyerhzm/bullet/releases)
- [Changelog](https://github.com/flyerhzm/bullet/blob/master/CHANGELOG.md)
- [Commits](flyerhzm/bullet@6.0.1...6.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @jhanggi
Bump rollbar from 2.21.0 to 2.22.1 (wyeworks#2063)
bf23cea 
Bumps [rollbar](https://github.com/rollbar/rollbar-gem) from 2.21.0 to 2.22.1.
- [Release notes](https://github.com/rollbar/rollbar-gem/releases)
- [Changelog](https://github.com/rollbar/rollbar-gem/blob/master/CHANGELOG.md)
- [Commits](rollbar/rollbar-gem@v2.21.0...v2.22.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @jhanggi
Bump oj from 3.9.0 to 3.9.1 (wyeworks#2065)
d0a4cf2 
Bumps [oj](https://github.com/ohler55/oj) from 3.9.0 to 3.9.1.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](ohler55/oj@v3.9.0...v3.9.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview @jhanggi
Bump capistrano from 3.11.0 to 3.11.1 (wyeworks#2064)
08b20e6 
Bumps [capistrano](https://github.com/capistrano/capistrano) from 3.11.0 to 3.11.1.
- [Release notes](https://github.com/capistrano/capistrano/releases)
- [Changelog](https://github.com/capistrano/capistrano/blob/master/CHANGELOG.md)
- [Commits](capistrano/capistrano@v3.11.0...v3.11.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
jhanggi and others added 21 commits February 24, 2020 16:31
@jhanggi
Use Uglifier with harmony in order to allow ES6 syntax. (wyeworks#2227)
054e33c 
# Release Notes

Tech task: Allow ES6 syntax in JS.

# Additional Context

This error came up on open stage: `Uglifier::Error: Unexpected token: keyword (const). To use ES6 syntax, harmony mode must be enabled with Uglifier.new(:harmony => true)`
@jhanggi
Shorten index name because oracle (wyeworks#2228)
44e10e0 
# Release Notes

Tech task: shorten index name for product display groups position field because it is too long for Oracle.

# Additional Context

Oracle has a limit of 30 characters. I had given it an explicit name because Mysql also has some restrictions around index names.

I added this as a separate migration so that if the previous migration (which I have now changed) has already run, it'll clean up the name there.
@jhanggi
Fix typo
f7f6365
@jhanggi
Fix account cloner spec when running under oracle (wyeworks#2230)
4502cc9 
# Release Notes

Tech task: Fix account membership cloner spec when running under Oracle.

# Additional Context

Mysql does a case-insensitive search, while Oracle is sensitive.
@dependabot-preview
Bump nokogiri from 1.10.8 to 1.10.9 (wyeworks#2234)
949f1ed 
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.8 to 1.10.9.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/v1.10.9/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.10.8...v1.10.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview
Bump bootsnap from 1.4.5 to 1.4.6 (wyeworks#2236)
327dae5 
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.5 to 1.4.6.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](Shopify/bootsnap@v1.4.5...v1.4.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview
Bump haml_lint from 0.34.2 to 0.35.0 (wyeworks#2233)
872d2c2 
Bumps [haml_lint](https://github.com/sds/haml-lint) from 0.34.2 to 0.35.0.
- [Release notes](https://github.com/sds/haml-lint/releases)
- [Changelog](https://github.com/sds/haml-lint/blob/master/CHANGELOG.md)
- [Commits](sds/haml-lint@v0.34.2...v0.35.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview
Bump oj from 3.10.2 to 3.10.3 (wyeworks#2237)
2e8de71 
Bumps [oj](https://github.com/ohler55/oj) from 3.10.2 to 3.10.3.
- [Release notes](https://github.com/ohler55/oj/releases)
- [Changelog](https://github.com/ohler55/oj/blob/develop/CHANGELOG.md)
- [Commits](ohler55/oj@v3.10.2...v3.10.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@jhanggi
[#152924] Prevent error when updating order with auto-scaled accessor…
5d6eadd 
…ies (wyeworks#2229)

# Release Notes

Fix error when modifying an order detail with auto-scaled accessories.

# Additional Context

To replicate:

- Create an instrument with an auto-scaled accessory
- Complete a reservation and add the auto-scaled accessory
- Visit the order detail popup
- Change the actual times
- Submit and you should get this error
@jhanggi
Fix print styles on Formio embeds (wyeworks#2232)
bc6dc51 
# Release Notes

Fix print styles on Formio embeds.

# Additional Context

When I changed from using raw html to more rails/haml-y syntax in wyeworks#2212, I switched to using `stylesheet_link_tag`. According to the [docs](https://apidock.com/rails/ActionView/Helpers/AssetTagHelper/stylesheet_link_tag), "For historical reasons, the ‘media’ attribute will always be present and defaults to “screen”, so you must explicitly set it to “all” for the stylesheet(s) to apply to all media types.".

So, because it was now `media="screen"`, the styles were not being applied to print.
@jhanggi
Fix journal format lookup to be string/symbol agnostic (wyeworks#2231)
3693817 
# Release Notes

Bug fix: The XLS spreadsheet was not being created for journals. The bug has not made it to any of the staging environments.

# Additional Context

After the refactoring in wyeworks#2206, we needed to make the format lookup symbol/string agnostic
@dependabot-preview
Bump will_paginate from 3.2.1 to 3.3.0 (wyeworks#2235)
f02db3b 
Bumps [will_paginate](https://github.com/mislav/will_paginate) from 3.2.1 to 3.3.0.
- [Release notes](https://github.com/mislav/will_paginate/releases)
- [Commits](mislav/will_paginate@v3.2.1...v3.3.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@jhanggi
[#140079] Improve product search (MySQL only) (wyeworks#2209)
8f52270 
# Release Notes

Improve product search responses, especially when searching for multiple words. For now, this only applies to MySQL.

For example: searching for "lsc W1 spinning disk" might return "LSC Andor Spinning Disk" and "LSC Nikon A1RSi" where it's matches a single word. Precedence is given to the result that matches more words. Before it would return no results.

# Additional Context

This uses MySQL's full text searching functionality.

It still may not be perfect, especially for things like misspellings, or word roots, but it's the best we can do without a fuller search engine, which would likely require additional infrastructure (e.g. Sphinx).

I have code that works for Oracle as well, but there are problems with the oracle adapter currently. I have PRs out for it, but I don't know how long that will take to go in. In the meantime, I'll open a PR here for it so you can see it. Some of the code in this PR may feel a little over-flexible, but it made sense with the Oracle support.
@cardoce
Change Charge For in Time Services to minutes in export raw csv (wyew…
1233ddb 
…orks#2242)

In the Raw Export for “Timed Services”, the “Charge For” column will populate with “Minutes”
@jhanggi
Update instrument dashboard label (wyeworks#2239)
57ebee3 
# Release Notes

Update label for enabling the instrument dashboard.

# Additional Context

See wyeworks#2205 for the original implementation.
@jhanggi
[#38893] Fix ordering of product groups on facility homepage (wyework…
7d04a93 
…s#2238)

# Release Notes

Fix ordering of product groups on facility homepage.

# Additional Context

I have no idea how I missed adding the `sorted` scope in the original PR.
@jhanggi
[#151928] Fix hard error on cross-facility Payment Sources (wyeworks#…
46848a4 
…2243)

# Release Notes

Fixes a hard error on global "Users > Payment Sources". (`/facilities/all/accounts`).

# Additional Context

This was broken by the removal of the `accountsfacility_id` column in wyeworks#1863. We didn't have a test around that view, which would have caught it. This changes the behavior slightly: before we were only showing global accounts before. But when you searched that restriction when away. Now on the page, it'll include credit card and POs. I also added a facility column that will appear in the cross-facility context.

# Screenshot

![Screen Shot 2020-03-06 at 2 13 10 PM](https://user-images.githubusercontent.com/1099111/76119228-9eba8f80-5fb4-11ea-8028-2f9c992e46ad.png)
@jhanggi
Fix circular dependency issue (wyeworks#2240)
3995099 
# Release Notes

Tech task: Fix circular dependency issue happening in Dartmouth.

# Additional context

I switched these over to `cattr_accessor` because I find the syntax a lot more readable. This came in from the product grouping in wyeworks#2215. 

I'm not quite sure exactly why, but enabling the SecureRooms engine prevents this error from happening. I know that it appends to the `Product.types` array, but why it doesn't cause the circular dependency, I don't really understand.

That's why this was fine in open and NU since they both have the engine enabled while Dartmouth does not.
@jhanggi
Tech task: Fix spurious spec failure (wyeworks#2241)
2d5977b 
# Release Notes

Tech task: Fix spurious test failure.

# Additional Context

```
Failure/Error: click_link "Clone Payment Source Memberships"

Capybara::Ambiguous:
  Ambiguous match, found 2 elements matching visible link "Clone Payment Source Memberships"

./vendor/bundle/ruby/2.5.0/gems/capybara-3.31.0/lib/capybara/node/finders.rb:300:in `block in synced_resolve'
./vendor/bundle/ruby/2.5.0/gems/capybara-3.31.0/lib/capybara/node/base.rb:83:in `synchronize'
./vendor/bundle/ruby/2.5.0/gems/capybara-3.31.0/lib/capybara/node/finders.rb:291:in `synced_resolve'
./vendor/bundle/ruby/2.5.0/gems/capybara-3.31.0/lib/capybara/node/finders.rb:52:in `find'
./vendor/bundle/ruby/2.5.0/gems/capybara-3.31.0/lib/capybara/node/actions.rb:42:in `click_link'
./vendor/bundle/ruby/2.5.0/gems/capybara-3.31.0/lib/capybara/session.rb:759:in `block (2 levels) in <class:Session>'
./vendor/bundle/ruby/2.5.0/gems/capybara-3.31.0/lib/capybara/dsl.rb:58:in `block (2 levels) in <module:DSL>'
./spec/system/admin/clones_account_memberships_spec.rb:37:in `block (3 levels) in <top (required)>'
```

This was super tricky to figure out. What it came down to is we have a couple users whose sequence of name coming out of the factory is out of sync with the sequence of email addresses. I think this happens where if you explicitly set the value in a `FactoryBot.create` it doesn't increment the sequence, and I know we do that in a few places.

So we had one user with name "User 724" and email "user722@example.com" and then another user with "User 726" and "user724@example.com". Because our user search is pretty generous (in order to support first name, last name, and full name searching), a search for "User 724" matches the first user's name and the second user's email address. 

That's why we were seeing two results come back which was then confusing capybara. I figured this out by throwing this code in there so I could actually see what was happening on the failures on CI. There's probably a way to do `save_and_open_page` on CI, but I don't know how.

```ruby
unless page.has_link?("Clone Payment Source Memberships", count: 1)
  raise "Too many links for user: #{original_user.name} -- All: #{User.all.map(&:name) }\n#{page.body}"
end
```

The detail is the query gets converted to `%user%724%` and then matched against the various columns. In general I'm ok with it being as lenient as it is and no one's complained about it. Better for the search to return more results than to not return a result.
@jhanggi
[#149739] Fix sorting when deciding most recent order (wyeworks#2246)
4425094 
# Release Notes

Fix "Add to Order" issue where the defaults may be coming from the wrong order detail.

# Additional Context

See wyeworks#2207 for the original implementation

In Oracle, it's possible that the IDs of the rows in `order_details` (or really in any table) may not be assigned in the order of the sequence. This is due to the way that Oracle caches values in a sequence: it preallocates them into a cache, but different nodes get their own cache. So you can end up with an `ORDER_BY id` being different than `ORDER BY created_at`.

In the future, we should consider how to ensure proper ordering (see the references), but that is out of scope of the current ticket.

A couple references:
https://asktom.oracle.com/pls/apex/f?p=100:11:::NO::P11_QUESTION_ID:9539374000346423410
https://stackoverflow.com/questions/13513936/oracle-sequence-value-are-not-ordered
https://stackoverflow.com/questions/4866959/oracle-rac-and-sequences
@jhanggi
[#38893] Add inactive tag to product names in groups (wyeworks#2247)
47c4255 
# Release Notes

Display "Inactive" next to product names in the product group management pages.

# Additional Context

Per the client:

> This would be helpful in terms of organizing currently Active products versus Inactive products when viewing, creating, and editing Display Groups.

I also moved "Hidden" in here to allow some sharing of code with the homepage (and getting rid of the hard-coded string in the view).
@joshea0 joshea0 requested a review from jhanggi as a code owner March 11, 2020 17:01
@joshea0 joshea0 force-pushed the latest_from_open_2020_03_11 branch from 5691211 to 51ad695 Compare March 11, 2020 17:10
joshea0 added 3 commits March 16, 2020 13:00
@joshea0
fix: specify Rails version in migration
37a2d3b
@joshea0
fix: update schema.rb to fix problems from merge
d0538f0
@joshea0
add have_content_i matcher and fix failing test by using it
7eeb5c6 
This test was failing because it was doing a case-sensitive search
for "Ordered Date..." but UConn's styles have added some styles
with `text-transform: uppercase` which was causing this test to break.

Adding a customer matcher have_content_i resolves this problem in a way
that should be suitable for nucore-uconn and nucore-open
@joshea0 joshea0 removed the request for review from jhanggi March 17, 2020 13:51
@joshea0
Copy link
Author

joshea0 commented Mar 23, 2020

Something went wrong during this merge process so I'm deleting this and starting again from a clean slate.

@joshea0 joshea0 closed this Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshea0 joshea0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joshea0 @vandrijevik @meara @jhanggi @arnamak @rolfrussell @cardoce