Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove newline to show FB and Twitter buttons on same line publiclab#…
…4821 (publiclab#4867) * Remove newline to show FB and Twitter buttons on same line publiclab#4821 Removing <br> tag was not simply enough, since facebook button root node is a div with display block. I am not that happy with this solution, because it relies on how Facebook renders its button, which can change at any time. Other solution I came up with was adding float:left and margin-right to twitter button, then it does not matter that Facebook button is block element, but still it relies on how twitter's script renders its button in iframe. Last solution I came up, but could not make work was wrapping both of them in divs and then position them based on our containers div with no regard what is inside. * Change solution to indepent of internals of social media buttons * Update app/views/sidebar/_dashboard.html.erb Typo, closing tag. Co-Authored-By: swiatek7 <swiatek7@gmail.com>
- Loading branch information