Remove newline to show FB and Twitter buttons on same line #4821
Labels
first-timers-only
They need to be well-formatted using the First-timers_Issue_Template.
has-pull-request
issues which already have a pull request solving it
HTML
Comments
grvsachdeva
added
first-timers-only
5 tasks
|
Hello |
|
As a first timer I find installation really difficult, because bundler version is not definied.
All of this is due to: |
|
Hi @swiatek7, sorry you have to encounter this error. We always try to be up-to-date with our docs and try to provide installation instructions which can help most contributors but yes, there is always scope for improvement. Do you think prerequisite section needs a addition? Thanks and keep us updated if you still face any error or require help. Thanks! |
|
Is someone else already working in this issue? |
I am working on this issue :) |
|
Hi @gauravano Unfortunately I had many issues with running this project and still can't make it happen.
|
|
Hi @swiatek7, can you try with |
|
@namangupta01 Then if I try to open localhost:3000 it works and console outputs: |
|
I would like to claim this issue. |
|
Can I claim this issue? |
|
Hi @meet2410shah @ShashankRahatekar, this issue is already claimed by @swiatek7 so please work on other issues. You can find more FTO issues at https://code.publiclab.org/#r=all and if you can't find any there, feel free to comment below and we'll try to point you to good issue or maybe open a new one. Thanks! |
|
@swiatek7 that's great, you are able to run the project. Have you opened PR for this issue yet? |
|
Hi @gauravano |
matvs
added a commit
to matvs/plots2
that referenced
this issue
Feb 20, 2019
…4821 Removing <br> tag was not simply enough, since facebook button root node is a div with display block. I am not that happy with this solution, because it relies on how Facebook renders its button, which can change at any time. Other solution I came up with was adding float:left and margin-right to twitter button, then it does not matter that Facebook button is block element, but still it relies on how twitter's script renders its button in iframe. Last solution I came up, but could not make work was wrapping both of them in divs and then position them based on our containers div with no regard what is inside.
|
Hi @gauravano I managed to fetch new CSS file :) |
This was referenced Feb 21, 2019
|
@gauravano I opened PR :) |
grvsachdeva
added
has-pull-request
grvsachdeva
pushed a commit
that referenced
this issue
Feb 21, 2019
* Remove newline to show FB and Twitter buttons on same line #4821 Removing <br> tag was not simply enough, since facebook button root node is a div with display block. I am not that happy with this solution, because it relies on how Facebook renders its button, which can change at any time. Other solution I came up with was adding float:left and margin-right to twitter button, then it does not matter that Facebook button is block element, but still it relies on how twitter's script renders its button in iframe. Last solution I came up, but could not make work was wrapping both of them in divs and then position them based on our containers div with no regard what is inside. * Change solution to indepent of internals of social media buttons * Update app/views/sidebar/_dashboard.html.erb Typo, closing tag. Co-Authored-By: swiatek7 <swiatek7@gmail.com>
Closed
icarito
pushed a commit
to icarito/plots2
that referenced
this issue
Apr 9, 2019
…4821 (publiclab#4867) * Remove newline to show FB and Twitter buttons on same line publiclab#4821 Removing <br> tag was not simply enough, since facebook button root node is a div with display block. I am not that happy with this solution, because it relies on how Facebook renders its button, which can change at any time. Other solution I came up with was adding float:left and margin-right to twitter button, then it does not matter that Facebook button is block element, but still it relies on how twitter's script renders its button in iframe. Last solution I came up, but could not make work was wrapping both of them in divs and then position them based on our containers div with no regard what is inside. * Change solution to indepent of internals of social media buttons * Update app/views/sidebar/_dashboard.html.erb Typo, closing tag. Co-Authored-By: swiatek7 <swiatek7@gmail.com>
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this issue
May 5, 2019
…4821 (publiclab#4867) * Remove newline to show FB and Twitter buttons on same line publiclab#4821 Removing <br> tag was not simply enough, since facebook button root node is a div with display block. I am not that happy with this solution, because it relies on how Facebook renders its button, which can change at any time. Other solution I came up with was adding float:left and margin-right to twitter button, then it does not matter that Facebook button is block element, but still it relies on how twitter's script renders its button in iframe. Last solution I came up, but could not make work was wrapping both of them in divs and then position them based on our containers div with no regard what is inside. * Change solution to indepent of internals of social media buttons * Update app/views/sidebar/_dashboard.html.erb Typo, closing tag. Co-Authored-By: swiatek7 <swiatek7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update:
Remove newline between the FB and Twitter buttons
Let's shift them on the same line by updating file. Also, there's a typo in the comment (at line 42) in the file, please remove that too. https://github.com/publiclab/plots2/blob/master/app/views/sidebar/_dashboard.html.erb#L42-L47
Also, attach the screenshot of the updated view.
💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
🤔❓ Questions?
Leave a comment below!
Is someone else already working on this?
We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
The text was updated successfully, but these errors were encountered: