Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing lines #4847

Closed
wants to merge 1 commit into from
Closed

Removing lines #4847

wants to merge 1 commit into from

Conversation

sodaney
Copy link

@sodaney sodaney commented Feb 18, 2019

Tbh, I am a first-time contributor. I didn't really know what should I do because I didn't understand much about issue description. So what I was just removing Facebook and Twitter buttons from line 42.

@plotsbot
Copy link
Collaborator

2 Messages
📖 @sodaney Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@grvsachdeva
Copy link
Member

hey @sodaney, please mention the issue you are trying to solve here. Thanks!

@SidharthBansal
Copy link
Member

@sodaney please mention the issue number so that we can help you.
Also there are some conflicts. Please rebase your pr.

@grvsachdeva
Copy link
Member

Hey @sodaney, I guess, you are trying to solve #4821. Actually, that issue is solved now and the goal of the issue was to show FB and Twitter button on the same line.

Let us know, if this PR is for any other issue. Closing this for now. Thanks!

@grvsachdeva grvsachdeva closed this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants