Rewrite #180
Rewrite #180
Conversation
examples/random_map.rs
Outdated
| layer_builder.for_each_tiles_mut(|tile_entity, tile_data| { | ||
| // True here refers to tile visibility. | ||
| *tile_data = Some(TileBundle::default()); | ||
| // Tile entity might not exist at this point so you'll need to create it. | ||
| if tile_entity.is_none() { | ||
| *tile_entity = Some(commands.spawn().id()); | ||
| for x in 0..640u32 { | ||
| for y in 0..640u32 { | ||
| let tile_pos = TilePos2d { x, y }; | ||
| let tile_entity = commands | ||
| .spawn() | ||
| .insert(tile_pos) | ||
| .insert(TileTexture(0)) | ||
| .insert(TilemapId(tilemap_entity)) | ||
| .insert(LastUpdate::default()) | ||
| .insert(TileVisible(true)) | ||
| .id(); | ||
| tile_storage.set(&tile_pos, Some(tile_entity)); | ||
| } | ||
| commands | ||
| .entity(tile_entity.unwrap()) | ||
| .insert(LastUpdate::default()); | ||
| }); | ||
| } |
There was a problem hiding this comment.
🙏🏻
To the completely ignorant of game dev person that I am, this is so much more intuitive. Can't wait for the post-rewrite version.
Rewrite: LDtk example
src/tiles/mod.rs
Outdated
| pub struct TileBundle { | ||
| pub position: TilePos2d, | ||
| pub texture: TileTexture, | ||
| pub tilemap_id: TilemapId, | ||
| pub visible: TileVisible, | ||
| pub flip: TileFlip, | ||
| } |
There was a problem hiding this comment.
Is there any play to support colors on tiles, like the old Tile component?
There was a problem hiding this comment.
Thanks for implementing this!
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Wiring up animation!
|
FWIW, I migrated a project to the rewrite branch and didn't have any issues. But I'm pretty much just loading a single static Tiled map. |
That's great news! Thanks for letting me know! 🙂 |
|
@StarArawn I think commit 926ceea would still be a good improvement for the rewrite. Do you want to cherry-pick it, or should I open a new PR? |
|
So, according to one of Bevy's rendering devs that import is going to be removed. It was suggested to just keep what I have for right now. |
|
I see! In that case the struct definition should be updated to https://github.com/bevyengine/bevy/blob/6752c9c59b3b81168ea6607767cbb519e5127976/crates/bevy_sprite/src/mesh2d/mesh2d_view_types.wgsl to match the Rust side of ViewUniform (this shader import was actually broken in the Bevy 0.8 release and fixed in a subsequent commit) |
Ideally I suppose we should use bevy's import. Until we can I think copying it into our shader is probably best. Edit: |
Closes: #170
Closes: #205
Closes: #140
Closes: #121
Closes: #71